From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11A5E188012; Fri, 15 Nov 2024 06:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731652821; cv=none; b=qzKW+vGWNiOevljn81xf3hUrjOISyWpSEphN30tz7J1ZUcQtygpHwCgE82wNQcoG52Xgdf+uG1TPCj7ljIbE2gPK8ymzcV6VCgzE/96NvA3nsYew3ogQKAaFHmFMVC9EObsQiWhfhxdOT2FkRv/bvEdtDqz4JDUE/8fqUoJAxf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731652821; c=relaxed/simple; bh=hINRQiSGWf3q079OZUEEiIQeB5m9vQeMIt9rxMoywao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vqomixjwyg4Fe7Xovb31VTC7QXU+o5rmc2lhXU8pGvIralkG8jH0h0SZNtAUZwMk1j7w9ZPHCDMwJQgOrGdpZm6p46A2udpRj7wUeej4JDBvLSpRzhz1L3VtgdaUWETWmAUDt1OMD6yZOwFKr2MmkHr2DgTwJPdkpR8eN5eYlA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UMBS4XcA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UMBS4XcA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F5E5C4CECF; Fri, 15 Nov 2024 06:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731652820; bh=hINRQiSGWf3q079OZUEEiIQeB5m9vQeMIt9rxMoywao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UMBS4XcAReVoJijTcaBQpvOwXiRYbnJO/74B1PUCOHErIqXoLRLpQK9XTWjg2cxGE OEeD+xuV8sy1m20wayZPtnRCmRRWV+cJ9Mig+DgW7OL6d1BSegYnjcAioluRTWZVvq /ZxrmnXNT+8rByBo+EvwQXNItvYVdpNK+0zRoKW8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zichen Xie , Mikulas Patocka Subject: [PATCH 4.19 24/52] dm-unstriped: cast an operand to sector_t to prevent potential uint32_t overflow Date: Fri, 15 Nov 2024 07:37:37 +0100 Message-ID: <20241115063723.730064258@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241115063722.845867306@linuxfoundation.org> References: <20241115063722.845867306@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zichen Xie commit 5a4510c762fc04c74cff264cd4d9e9f5bf364bae upstream. This was found by a static analyzer. There may be a potential integer overflow issue in unstripe_ctr(). uc->unstripe_offset and uc->unstripe_width are defined as "sector_t"(uint64_t), while uc->unstripe, uc->chunk_size and uc->stripes are all defined as "uint32_t". The result of the calculation will be limited to "uint32_t" without correct casting. So, we recommend adding an extra cast to prevent potential integer overflow. Fixes: 18a5bf270532 ("dm: add unstriped target") Signed-off-by: Zichen Xie Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-unstripe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/md/dm-unstripe.c +++ b/drivers/md/dm-unstripe.c @@ -84,8 +84,8 @@ static int unstripe_ctr(struct dm_target } uc->physical_start = start; - uc->unstripe_offset = uc->unstripe * uc->chunk_size; - uc->unstripe_width = (uc->stripes - 1) * uc->chunk_size; + uc->unstripe_offset = (sector_t)uc->unstripe * uc->chunk_size; + uc->unstripe_width = (sector_t)(uc->stripes - 1) * uc->chunk_size; uc->chunk_shift = is_power_of_2(uc->chunk_size) ? fls(uc->chunk_size) - 1 : 0; tmp_len = ti->len;