From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931DCEAD0; Fri, 15 Nov 2024 06:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653117; cv=none; b=HH6JJp486dx1goFQF/hdAhzcu9nmjwxwSPneWpL4BmmXBLU7iySxB9dcbC/J9cLt28B/kvGKnT3JE3f1J9G4KUZBOyZzmbp5R5yAxCoPNj9nl1xzscGbGS0mipTAGyjAtwmmBaFXJB7iek12W8RPQ4G8CyZqirsRNlksRYySRHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653117; c=relaxed/simple; bh=4cxRw/yp9F+kGTlyLY6jyfZWQf//u/yUDJALJc8IikA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LTwCOU3H3J4mNACvOqnzSSG8MujmBqagpdHnMyg62Xg6smawqq/CsnUDU5XkvRvwv1ApiebVmzSoNoIbUwSuoEG3gAS39tx5aIzmyG+CFxxFNmkNQdzmIeNNfUb7hFsa7kJuED0dxdftjejSBzlpRPuMiCzG/ZRDiDMQxNlWjaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yf6wine6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yf6wine6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFB59C4CECF; Fri, 15 Nov 2024 06:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731653117; bh=4cxRw/yp9F+kGTlyLY6jyfZWQf//u/yUDJALJc8IikA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yf6wine64FnGthjcuRaACjjuekNUnug/+mDaL+pAIqNi9BfBrfTmBDI6zi5+mYV9h aCHXr95SjF1V4w5ieRfRlZHI35QbN6uHC/qC6D7mQX0k/Hn5TtU9J9jDAUqy6Sm47m 5GpYfFGAQimgU61WlEE9qzXAdv0xqjQdYWcXVSeY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com, Alessandro Zanni , Jan Kara , Christian Brauner , Sasha Levin Subject: [PATCH 5.4 59/66] fs: Fix uninitialized value issue in from_kuid and from_kgid Date: Fri, 15 Nov 2024 07:38:08 +0100 Message-ID: <20241115063724.971046318@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241115063722.834793938@linuxfoundation.org> References: <20241115063722.834793938@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alessandro Zanni [ Upstream commit 15f34347481648a567db67fb473c23befb796af5 ] ocfs2_setattr() uses attr->ia_mode, attr->ia_uid and attr->ia_gid in a trace point even though ATTR_MODE, ATTR_UID and ATTR_GID aren't set. Initialize all fields of newattrs to avoid uninitialized variables, by checking if ATTR_MODE, ATTR_UID, ATTR_GID are initialized, otherwise 0. Reported-by: syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=6c55f725d1bdc8c52058 Signed-off-by: Alessandro Zanni Link: https://lore.kernel.org/r/20241017120553.55331-1-alessandro.zanni87@gmail.com Reviewed-by: Jan Kara Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/ocfs2/file.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 0c62cb90d63dd..3bbeea2e60f70 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -1133,9 +1133,12 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr) trace_ocfs2_setattr(inode, dentry, (unsigned long long)OCFS2_I(inode)->ip_blkno, dentry->d_name.len, dentry->d_name.name, - attr->ia_valid, attr->ia_mode, - from_kuid(&init_user_ns, attr->ia_uid), - from_kgid(&init_user_ns, attr->ia_gid)); + attr->ia_valid, + attr->ia_valid & ATTR_MODE ? attr->ia_mode : 0, + attr->ia_valid & ATTR_UID ? + from_kuid(&init_user_ns, attr->ia_uid) : 0, + attr->ia_valid & ATTR_GID ? + from_kgid(&init_user_ns, attr->ia_gid) : 0); /* ensuring we don't even attempt to truncate a symlink */ if (S_ISLNK(inode->i_mode)) -- 2.43.0