From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E954EAD0; Fri, 15 Nov 2024 06:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653144; cv=none; b=H+3QLJZXBHa8k8yHth/SEZrDCXrHyZ7d2R02WrGd8TcUln2GWCqnYCZ28IC/0gBEB5DzeSgsaBfVcyDaueSTGXtvDNjPpU6j79NnP16sa/AYmOR/4Gw1UsjcJWpxEW8q0bVEDFU6NJSjkBgpqODwfVBNEl7GbwOxDZopcCzOvx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653144; c=relaxed/simple; bh=tgG797msYoN74wgraK9s4WKonhCtafz/AzEE5KPcYVI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rvvQ+05ziyVrpzEmF0scEQhc3XxmO1+f0FgpuvgFMGv+35WFhV4lEVVqj6aWZy3Kdsv4+OcNpRlbRoTqfZmKVGdCpKHAUZRYbydm04RfPrVHjSaQeIOkNmesHZGC4txptgY8fhUdF6o2CfcJojniDQY67XrTO6huXFymBOIEMYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BUz53xTY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BUz53xTY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16E20C4CECF; Fri, 15 Nov 2024 06:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731653144; bh=tgG797msYoN74wgraK9s4WKonhCtafz/AzEE5KPcYVI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BUz53xTYhLnVGmb9pMkv1z3KRaGem+jzie4a1r8NCbx56ZA+hDbnL7YNrnmIoZeGk YsgYeYdURGeWI1IOeR+5Y4W8l4ymj+Oc5FpiIHXE3E+FOuBU1EYYogh3dyx620vFn9 S2Eyo4Wem+ibr0xwXKwFxQHc4iEw9fSbYlH+dLyo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vlastimil Babka , Dominique Martinet , Thorsten Leemhuis , Linus Torvalds , Omar Sandoval Subject: [PATCH 5.4 66/66] 9p: fix slab cache name creation for real Date: Fri, 15 Nov 2024 07:38:15 +0100 Message-ID: <20241115063725.221391282@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241115063722.834793938@linuxfoundation.org> References: <20241115063722.834793938@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Linus Torvalds commit a360f311f57a36e96d88fa8086b749159714dcd2 upstream. This was attempted by using the dev_name in the slab cache name, but as Omar Sandoval pointed out, that can be an arbitrary string, eg something like "/dev/root". Which in turn trips verify_dirent_name(), which fails if a filename contains a slash. So just make it use a sequence counter, and make it an atomic_t to avoid any possible races or locking issues. Reported-and-tested-by: Omar Sandoval Link: https://lore.kernel.org/all/ZxafcO8KWMlXaeWE@telecaster.dhcp.thefacebook.com/ Fixes: 79efebae4afc ("9p: Avoid creating multiple slab caches with the same name") Acked-by: Vlastimil Babka Cc: Dominique Martinet Cc: Thorsten Leemhuis Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- net/9p/client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/net/9p/client.c +++ b/net/9p/client.c @@ -1001,6 +1001,7 @@ error: struct p9_client *p9_client_create(const char *dev_name, char *options) { int err; + static atomic_t seqno = ATOMIC_INIT(0); struct p9_client *clnt; char *client_id; char *cache_name; @@ -1056,7 +1057,8 @@ struct p9_client *p9_client_create(const if (err) goto close_trans; - cache_name = kasprintf(GFP_KERNEL, "9p-fcall-cache-%s", dev_name); + cache_name = kasprintf(GFP_KERNEL, + "9p-fcall-cache-%u", atomic_inc_return(&seqno)); if (!cache_name) { err = -ENOMEM; goto close_trans;