From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1C6188015; Fri, 15 Nov 2024 06:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653860; cv=none; b=I/E1UQrcuS28ObI9UflJkiTpAtOA5OX0CVgLyxdoM6MRxmECeSqeVETZsKJAcx8T3uZCo/7ZwINn5FCOq9/YnLLoukcBg62ouqY7IFyNcJ2X/ma985+F5cNBaGEg3hXD6mUUgpDHMn6KtsEd7QE+CXj+72NwEopJX6XUGRWlZgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653860; c=relaxed/simple; bh=DBWgE+uDeUiVbv4UmiPFCjLd9KHRCsO4pz4NEMd4g6U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iqBo5i6W8karkpOV1aX6vk3/oZZqYlSjoSFi6TQRPViAIpIfkDGI9pFot98gWvodSwQ9XAGNupe/EmsV+l0tBvWga4/sjn9DWYWNUC5n9BqrnIyAP/trlkcnOzoyzwkkBtDI4JbKBHmuGxVeZjY9v823qdik8NRSsGaOD+SkvPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cLpFFbYz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cLpFFbYz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82D94C4CECF; Fri, 15 Nov 2024 06:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731653860; bh=DBWgE+uDeUiVbv4UmiPFCjLd9KHRCsO4pz4NEMd4g6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cLpFFbYzQOobruf1FiGLXVQd4aZdhA4bXWcrt1+NglGo3YRdXwtHvgC+NPDkjNTt2 RavO2Rm/Oj9sk8star16j8GDwTXjfRSmFGosaVvff8JNSMMwZgzIAtZr2VyNdqeNIb KZLB9rNUzDPD8+VVHk0ZCjHO15i68ofRj5lsEAUA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qi Xi , kernel test robot , Baoquan He , Dave Young , Michael Holzheu , Vivek Goyal , Wang ShaoBo , Andrew Morton Subject: [PATCH 5.10 55/82] fs/proc: fix compile warning about variable vmcore_mmap_ops Date: Fri, 15 Nov 2024 07:38:32 +0100 Message-ID: <20241115063727.542202966@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241115063725.561151311@linuxfoundation.org> References: <20241115063725.561151311@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qi Xi commit b8ee299855f08539e04d6c1a6acb3dc9e5423c00 upstream. When build with !CONFIG_MMU, the variable 'vmcore_mmap_ops' is defined but not used: >> fs/proc/vmcore.c:458:42: warning: unused variable 'vmcore_mmap_ops' 458 | static const struct vm_operations_struct vmcore_mmap_ops = { Fix this by only defining it when CONFIG_MMU is enabled. Link: https://lkml.kernel.org/r/20241101034803.9298-1-xiqi2@huawei.com Fixes: 9cb218131de1 ("vmcore: introduce remap_oldmem_pfn_range()") Signed-off-by: Qi Xi Reported-by: kernel test robot Closes: https://lore.kernel.org/lkml/202410301936.GcE8yUos-lkp@intel.com/ Cc: Baoquan He Cc: Dave Young Cc: Michael Holzheu Cc: Vivek Goyal Cc: Wang ShaoBo Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- fs/proc/vmcore.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -446,10 +446,6 @@ static vm_fault_t mmap_vmcore_fault(stru #endif } -static const struct vm_operations_struct vmcore_mmap_ops = { - .fault = mmap_vmcore_fault, -}; - /** * vmcore_alloc_buf - allocate buffer in vmalloc memory * @sizez: size of buffer @@ -477,6 +473,11 @@ static inline char *vmcore_alloc_buf(siz * virtually contiguous user-space in ELF layout. */ #ifdef CONFIG_MMU + +static const struct vm_operations_struct vmcore_mmap_ops = { + .fault = mmap_vmcore_fault, +}; + /* * remap_oldmem_pfn_checked - do remap_oldmem_pfn_range replacing all pages * reported as not being ram with the zero page.