From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1860A196; Tue, 19 Nov 2024 00:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731977257; cv=none; b=Lj1DVgDaaHk6fO7vZYxsvmtQamNUips2+2a1lS2vtNjO1B61iTWTRNOPltAwQETpAokT2aw9GDSZxERJ9JAxoqgWnQT+XAaIsWQc6Zy0R7aJBOSQsQZi6rydK5S9Jf5NfUxt4bInYwx9ZeaQ6gpXk8oohUzjmi2aVwQKHBOfJy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731977257; c=relaxed/simple; bh=HfJjDxVHH7DeLmy5LOX0yFADowwiC4wUFP0XtIYNC84=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=borvOeCuXR/q3s3EyknpH3tcS5se7tS2KBz1Pug5OPZLD/G7amlPYLPnUSnZZ6fxfJEifwGfMIQSMBvlMevqbge/Bws/CbdxjWBOytvrkPpFsf0Sck0QY/laczhkkYOvn6AKnPSI42TRPBEdbDwwb2YNja4RWBICTtOhGfDAwG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dY+Q7Bip; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dY+Q7Bip" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 223D2C4CED0; Tue, 19 Nov 2024 00:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731977256; bh=HfJjDxVHH7DeLmy5LOX0yFADowwiC4wUFP0XtIYNC84=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dY+Q7BipWBP+B2rUxKXt/GCgHqZmUOnKp6eRyPZ4/eMRuOwqk/aS1gu5dLBUTRoY3 kMNrEopCgNnBbtUkwwHO2ItVMI+TJkjJdXDW3/WsMFB8HHe40SOXlwmYZay2M30iya YNtBaZLt62RuzyDN85dV3MG8aKtjtWghs/87t4fPFG0o/aOuuq3uM82x7KXpaaQyfM WmXornVmAs3aOcrlHzYmLiOS6tvPToCofOnKZ18A/Nfyf1JLu6dyFcq4Ja+Z+QPUXa 1oHcM2k7dp736ADEJYjIyPHrl72DQ1Xp18MOLmUJlvs499w201E5Urx+glmp82q/pm g9lHakFvnFmqA== From: cel@kernel.org To: Cc: , Jeff Layton , Chuck Lever Subject: [PATCH 5.10 2/5] NFSD: Async COPY result needs to return a write verifier Date: Mon, 18 Nov 2024 19:47:29 -0500 Message-ID: <20241119004732.4703-3-cel@kernel.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241119004732.4703-1-cel@kernel.org> References: <20241119004732.4703-1-cel@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever [ Upstream commit 9ed666eba4e0a2bb8ffaa3739d830b64d4f2aaad ] Currently, when NFSD handles an asynchronous COPY, it returns a zero write verifier, relying on the subsequent CB_OFFLOAD callback to pass the write verifier and a stable_how4 value to the client. However, if the CB_OFFLOAD never arrives at the client (for example, if a network partition occurs just as the server sends the CB_OFFLOAD operation), the client will never receive this verifier. Thus, if the client sends a follow-up COMMIT, there is no way for the client to assess the COMMIT result. The usual recovery for a missing CB_OFFLOAD is for the client to send an OFFLOAD_STATUS operation, but that operation does not carry a write verifier in its result. Neither does it carry a stable_how4 value, so the client /must/ send a COMMIT in this case -- which will always fail because currently there's still no write verifier in the COPY result. Thus the server needs to return a normal write verifier in its COPY result even if the COPY operation is to be performed asynchronously. If the server recognizes the callback stateid in subsequent OFFLOAD_STATUS operations, then obviously it has not restarted, and the write verifier the client received in the COPY result is still valid and can be used to assess a COMMIT of the copied data, if one is needed. Reviewed-by: Jeff Layton [ cel: adjusted to apply to origin/linux-5.10.y ] Signed-off-by: Chuck Lever --- fs/nfsd/nfs4proc.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index fbd42c1a3fcd..3a445b78edd5 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -718,15 +718,6 @@ nfsd4_access(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, &access->ac_supported); } -static void gen_boot_verifier(nfs4_verifier *verifier, struct net *net) -{ - __be32 *verf = (__be32 *)verifier->data; - - BUILD_BUG_ON(2*sizeof(*verf) != sizeof(verifier->data)); - - nfsd_copy_write_verifier(verf, net_generic(net, nfsd_net_id)); -} - static __be32 nfsd4_commit(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, union nfsd4_op_u *u) @@ -1594,7 +1585,6 @@ static void nfsd4_init_copy_res(struct nfsd4_copy *copy, bool sync) test_bit(NFSD4_COPY_F_COMMITTED, ©->cp_flags) ? NFS_FILE_SYNC : NFS_UNSTABLE; nfsd4_copy_set_sync(copy, sync); - gen_boot_verifier(©->cp_res.wr_verifier, copy->cp_clp->net); } static ssize_t _nfsd_copy_file_range(struct nfsd4_copy *copy, @@ -1765,9 +1755,14 @@ static __be32 nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, union nfsd4_op_u *u) { - struct nfsd4_copy *copy = &u->copy; - __be32 status; + struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id); struct nfsd4_copy *async_copy = NULL; + struct nfsd4_copy *copy = &u->copy; + struct nfsd42_write_res *result; + __be32 status; + + result = ©->cp_res; + nfsd_copy_write_verifier((__be32 *)&result->wr_verifier.data, nn); copy->cp_clp = cstate->clp; if (nfsd4_ssc_is_inter(copy)) { @@ -1787,8 +1782,6 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, memcpy(©->fh, &cstate->current_fh.fh_handle, sizeof(struct knfsd_fh)); if (nfsd4_copy_is_async(copy)) { - struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id); - status = nfserrno(-ENOMEM); async_copy = kzalloc(sizeof(struct nfsd4_copy), GFP_KERNEL); if (!async_copy) @@ -1800,8 +1793,8 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, goto out_err; if (!nfs4_init_copy_state(nn, copy)) goto out_err; - memcpy(©->cp_res.cb_stateid, ©->cp_stateid.cs_stid, - sizeof(copy->cp_res.cb_stateid)); + memcpy(&result->cb_stateid, ©->cp_stateid.cs_stid, + sizeof(result->cb_stateid)); dup_copy_fields(copy, async_copy); async_copy->copy_task = kthread_create(nfsd4_do_async_copy, async_copy, "%s", "copy thread"); -- 2.47.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 089C1146D6A for ; Tue, 19 Nov 2024 12:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732019489; cv=none; b=jny2MyngichU5PpmHDxB3ieJGh+AW+g3a+HwlI2/yFu8g2lfINje6Ys2XtYWInrz0+sQJ+jm3hfM7cTTzZe8A4Q+alh1IJD/hKfBf6aPwr3xNZYmYeZCJuZoj7qHpFyR+bkGHvWzFzWJrMCjYcbrZtjDABr8RMvjV2rQ1/eZWH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732019489; c=relaxed/simple; bh=ewDonmJg12JCSH80v8DxUFCJWO+WhrrDvoBrQbRNYYg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fIqBQnaVTQF788EAJG+NEIrBdVmoPiEsxD9RkN94dIOY9deAV6hOB18to0G7sLqiBwpoPldysZupPrXUlO9xDlvJjH2uaQT3GD1ykiz2bnRKJBXzfZF6lNBD8308z4Md3+oxFC1E1dMLzMZgXxePqAuXrXJbJCynrs990NqGb1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BcPDpjmM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BcPDpjmM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F7C7C4CECF; Tue, 19 Nov 2024 12:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732019488; bh=ewDonmJg12JCSH80v8DxUFCJWO+WhrrDvoBrQbRNYYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BcPDpjmMJWIoPRBWNyf1j+SN1NwWWjV2tfngmfDaKCaWap9uCzsibzpNhCMht4AfF WaFnoBsCgrZR6ymzgjlywBeO9A3y0xtWNKit1knhqVWVFADAat0tD9c2YjoeBNWJXw vIk7842Nca7g3Tjr6ejgSc/EEf7lifjIqvgTYs7ZLpAXl93YagVvlwUXp/hPhIZ7+k HLhg+UXKCfLgWsqCwwUj80danRFRIVp3kME9ltOB10AqVTODVi84kARmNC1QMDZflV eYfQKeiMyOrp0LGmWBkP6Ok2Oon8nj9R3AOYAsnQZBhoE4j9fbeNUPL1a3wOfGXjcs KWwS53xxNANDQ== From: Sasha Levin To: stable@vger.kernel.org Cc: cel@kernel.org, Sasha Levin Subject: Re: [PATCH 5.10 2/5] NFSD: Async COPY result needs to return a write verifier Date: Tue, 19 Nov 2024 07:31:27 -0500 Message-ID: <20241119004732.4703-3-cel@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241119004732.4703-3-cel@kernel.org> References: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: <20241119123127.ilGcS3Vc-70K4CJc3zrDHs43Q9QXdB9jTqIwGP299J4@z> [ Sasha's backport helper bot ] Hi, The upstream commit SHA1 provided is correct: 9ed666eba4e0a2bb8ffaa3739d830b64d4f2aaad WARNING: Author mismatch between patch and upstream commit: Backport author: cel@kernel.org Commit author: Chuck Lever Commit in newer trees: |-----------------|----------------------------------------------| | 6.11.y | Present (different SHA1: ea5fb07d126d) | | 6.6.y | Not found | | 6.1.y | Not found | | 5.15.y | Not found | | 5.10.y | Not found | |-----------------|----------------------------------------------| Note: The patch differs from the upstream commit: --- --- - 2024-11-19 02:04:52.531497218 -0500 +++ /tmp/tmp.dacUqCgtri 2024-11-19 02:04:52.526625055 -0500 @@ -1,3 +1,5 @@ +[ Upstream commit 9ed666eba4e0a2bb8ffaa3739d830b64d4f2aaad ] + Currently, when NFSD handles an asynchronous COPY, it returns a zero write verifier, relying on the subsequent CB_OFFLOAD callback to pass the write verifier and a stable_how4 value to the client. @@ -25,16 +27,17 @@ is needed. Reviewed-by: Jeff Layton +[ cel: adjusted to apply to origin/linux-5.10.y ] Signed-off-by: Chuck Lever --- - fs/nfsd/nfs4proc.c | 23 ++++++++--------------- - 1 file changed, 8 insertions(+), 15 deletions(-) + fs/nfsd/nfs4proc.c | 25 +++++++++---------------- + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c -index 963a02e179a0a..231c6035602f6 100644 +index fbd42c1a3fcd..3a445b78edd5 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c -@@ -752,15 +752,6 @@ nfsd4_access(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, +@@ -718,15 +718,6 @@ nfsd4_access(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, &access->ac_supported); } @@ -50,7 +53,7 @@ static __be32 nfsd4_commit(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, union nfsd4_op_u *u) -@@ -1632,7 +1623,6 @@ static void nfsd4_init_copy_res(struct nfsd4_copy *copy, bool sync) +@@ -1594,7 +1585,6 @@ static void nfsd4_init_copy_res(struct nfsd4_copy *copy, bool sync) test_bit(NFSD4_COPY_F_COMMITTED, ©->cp_flags) ? NFS_FILE_SYNC : NFS_UNSTABLE; nfsd4_copy_set_sync(copy, sync); @@ -58,30 +61,24 @@ } static ssize_t _nfsd_copy_file_range(struct nfsd4_copy *copy, -@@ -1805,9 +1795,11 @@ static __be32 +@@ -1765,9 +1755,14 @@ static __be32 nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, union nfsd4_op_u *u) { +- struct nfsd4_copy *copy = &u->copy; +- __be32 status; + struct nfsd_net *nn = net_generic(SVC_NET(rqstp), nfsd_net_id); -+ struct nfsd4_copy *async_copy = NULL; - struct nfsd4_copy *copy = &u->copy; + struct nfsd4_copy *async_copy = NULL; ++ struct nfsd4_copy *copy = &u->copy; + struct nfsd42_write_res *result; - __be32 status; -- struct nfsd4_copy *async_copy = NULL; - - /* - * Currently, async COPY is not reliable. Force all COPY -@@ -1816,6 +1808,9 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, - */ - nfsd4_copy_set_sync(copy, true); - ++ __be32 status; ++ + result = ©->cp_res; + nfsd_copy_write_verifier((__be32 *)&result->wr_verifier.data, nn); -+ + copy->cp_clp = cstate->clp; if (nfsd4_ssc_is_inter(copy)) { - trace_nfsd_copy_inter(copy); -@@ -1840,8 +1835,6 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, +@@ -1787,8 +1782,6 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, memcpy(©->fh, &cstate->current_fh.fh_handle, sizeof(struct knfsd_fh)); if (nfsd4_copy_is_async(copy)) { @@ -90,7 +87,7 @@ status = nfserrno(-ENOMEM); async_copy = kzalloc(sizeof(struct nfsd4_copy), GFP_KERNEL); if (!async_copy) -@@ -1853,8 +1846,8 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, +@@ -1800,8 +1793,8 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, goto out_err; if (!nfs4_init_copy_state(nn, copy)) goto out_err; @@ -101,3 +98,6 @@ dup_copy_fields(copy, async_copy); async_copy->copy_task = kthread_create(nfsd4_do_async_copy, async_copy, "%s", "copy thread"); +-- +2.47.0 + --- Results of testing on various branches: | Branch | Patch Apply | Build Test | |---------------------------|-------------|------------| | stable/linux-5.10.y | Success | Success |