From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6502E25634; Tue, 19 Nov 2024 00:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731977257; cv=none; b=MXa70MVnDuMJr9UtxK9uOMbZtHWc6Y79p8tmCM2cz0PV5jPNrvxOmOAOtPNv/HzHPmCFAT1MmDwljf+9/rZgHLgQRmQoIE8c502aXJ93fJNiOoiIcqTM5t8IkcDQcRlFvgg3U6eGB/yx/BH8N1iM7kVxq/C4NB/iNu6dpJ3eOc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731977257; c=relaxed/simple; bh=azDb3efhWoEbDpj2uvsfbeMcNcSSybcxGfwNnl/LbgI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tD3jCw/BZw4js3FXTnIrXSrJhndKSfogS5QudpN2LK56jXRVZM2rlQHp40YkKrkXmgjDAZkoouhxhW5goiONDQ0x9WA5Jot7iRj8R0fbFT5s9180bRmHD364rDtiTeHzZftvGxStPjDe36Lg4oxFl8OCdJo5eISNRK5ieAQYSfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oT6QTF75; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oT6QTF75" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC2BCC4CECF; Tue, 19 Nov 2024 00:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731977257; bh=azDb3efhWoEbDpj2uvsfbeMcNcSSybcxGfwNnl/LbgI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oT6QTF75J7yUrZ80RndjWF2m5lRkP+XwYOyKfPhGpBaEOnl1H38c5T903jS9DNOg7 PHBfbx1ZK9VG4PjJc3RXMOybDg6iRV5VAJn02CzuH4HkNL5yNHZlOlVBE4zEV5SD3e MbnP9PhPC4NqXKIeTzaKnOabaN/G1BRA4oogp25hqVoGmr0CWtf4T+8b2M8ZUkgzom x8XcbogiCKcii+om81pz2jlLazqUuWMebNvqVjxnM3AczdgHgQTm87EvOqU0qvwvtK E1iga99kOCx1c/BICmcIIKfwXglN3skO07oPvi2m3Rs+5qxv6sUao9oiCic5YUWYI4 QOwU+RADuDLrg== From: cel@kernel.org To: Cc: , Jeff Layton , Chuck Lever Subject: [PATCH 5.10 3/5] NFSD: Limit the number of concurrent async COPY operations Date: Mon, 18 Nov 2024 19:47:30 -0500 Message-ID: <20241119004732.4703-4-cel@kernel.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241119004732.4703-1-cel@kernel.org> References: <20241119004732.4703-1-cel@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever [ Upstream commit aadc3bbea163b6caaaebfdd2b6c4667fbc726752 ] Nothing appears to limit the number of concurrent async COPY operations that clients can start. In addition, AFAICT each async COPY can copy an unlimited number of 4MB chunks, so can run for a long time. Thus IMO async COPY can become a DoS vector. Add a restriction mechanism that bounds the number of concurrent background COPY operations. Start simple and try to be fair -- this patch implements a per-namespace limit. An async COPY request that occurs while this limit is exceeded gets NFS4ERR_DELAY. The requesting client can choose to send the request again after a delay or fall back to a traditional read/write style copy. If there is need to make the mechanism more sophisticated, we can visit that in future patches. Cc: stable@vger.kernel.org Reviewed-by: Jeff Layton Link: https://nvd.nist.gov/vuln/detail/CVE-2024-49974 Signed-off-by: Chuck Lever --- fs/nfsd/netns.h | 1 + fs/nfsd/nfs4proc.c | 11 +++++++++-- fs/nfsd/nfs4state.c | 1 + fs/nfsd/xdr4.h | 1 + 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h index 548422b24a7d..41c750f34473 100644 --- a/fs/nfsd/netns.h +++ b/fs/nfsd/netns.h @@ -152,6 +152,7 @@ struct nfsd_net { u32 s2s_cp_cl_id; struct idr s2s_cp_stateids; spinlock_t s2s_cp_lock; + atomic_t pending_async_copies; /* * Version information diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 3a445b78edd5..9718af3c2611 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1244,6 +1244,7 @@ static void nfs4_put_copy(struct nfsd4_copy *copy) { if (!refcount_dec_and_test(©->refcount)) return; + atomic_dec(©->cp_nn->pending_async_copies); kfree(copy->cp_src); kfree(copy); } @@ -1782,10 +1783,16 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, memcpy(©->fh, &cstate->current_fh.fh_handle, sizeof(struct knfsd_fh)); if (nfsd4_copy_is_async(copy)) { - status = nfserrno(-ENOMEM); async_copy = kzalloc(sizeof(struct nfsd4_copy), GFP_KERNEL); if (!async_copy) goto out_err; + async_copy->cp_nn = nn; + /* Arbitrary cap on number of pending async copy operations */ + if (atomic_inc_return(&nn->pending_async_copies) > + (int)rqstp->rq_pool->sp_nrthreads) { + atomic_dec(&nn->pending_async_copies); + goto out_err; + } INIT_LIST_HEAD(&async_copy->copies); refcount_set(&async_copy->refcount, 1); async_copy->cp_src = kmalloc(sizeof(*async_copy->cp_src), GFP_KERNEL); @@ -1824,7 +1831,7 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, } if (async_copy) cleanup_async_copy(async_copy); - status = nfserrno(-ENOMEM); + status = nfserr_jukebox; goto out; } diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 18d64a9312a7..5547db4db8e6 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -8088,6 +8088,7 @@ static int nfs4_state_create_net(struct net *net) spin_lock_init(&nn->client_lock); spin_lock_init(&nn->s2s_cp_lock); idr_init(&nn->s2s_cp_stateids); + atomic_set(&nn->pending_async_copies, 0); spin_lock_init(&nn->blocked_locks_lock); INIT_LIST_HEAD(&nn->blocked_locks_lru); diff --git a/fs/nfsd/xdr4.h b/fs/nfsd/xdr4.h index a034b9b62137..15a617bece00 100644 --- a/fs/nfsd/xdr4.h +++ b/fs/nfsd/xdr4.h @@ -574,6 +574,7 @@ struct nfsd4_copy { struct nfsd4_ssc_umount_item *ss_nsui; struct nfs_fh c_fh; nfs4_stateid stateid; + struct nfsd_net *cp_nn; }; static inline void nfsd4_copy_set_sync(struct nfsd4_copy *copy, bool sync) -- 2.47.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B8F1C07DB for ; Tue, 19 Nov 2024 12:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732019433; cv=none; b=ftKH6NBKVqOeuKnrmpTLPCWICohQAP+C/OnejE7AWnuiqXpO4Kf84jazMaH7foLsX1HOgVz1KQnhvn+RSo5JLgBrzNoJ7JhGcmoDppdaN1N4VGs3UTjq5MRG3ABBGI0UAeG2xj+zYfoO/nwnGoV5TTLpnqlxUjFycJN4dLMft2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732019433; c=relaxed/simple; bh=fTvg/sitrmN4eD0HQpZcoCmcG96tJB2Cja1EPovJnso=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MfCzdcelZpIgxfsaICE0WANgM+ympCx8ax4K7wzGItCX8qXr5OhrZgoq6pi9No5rqOkJ9hFU/Gm0PwqnUYrUJS71+9mk9ND09IrvPOi2T7xF4aXMfWqqJII6P3aa+s+9zEK7hYRRg+VJ6XdiLxpcq6ELRLKO+7f+onoFYej8TBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UJ3YS44Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UJ3YS44Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8E00C4CECF; Tue, 19 Nov 2024 12:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732019433; bh=fTvg/sitrmN4eD0HQpZcoCmcG96tJB2Cja1EPovJnso=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UJ3YS44Q0GUmPC20tYdWUpvoywbVXSYZRMG9IeNLqMLTvQR2D+5NJE//Ogb1wH+np FhT9SqFRcf6PnCeWfce5qYuBR8OkCocBuiumK0lr9snmx0AKSXQfbZDltGu7sEc8nb B7mwx70OTxnycbsZWvBgzzOpsxRVeiHmID63yy2+ZLHxYJpCBBIzN9mYdhT6ejvl5b +kMLEvlEGZ2dBFkqLJmrjTKoR+XfQZB9Jdo4X2zWHHtR9svbPG3dGuFLnK2QqVDL7M kRmIO+ClHz7jkb4Oxd4DtJuAALa3Ca5BQzKeYGj+3zo8OVqGd5qNTWIClcdKef3/BT s8wQ3rmRlnjxg== From: Sasha Levin To: stable@vger.kernel.org Cc: cel@kernel.org, Sasha Levin Subject: Re: [PATCH 5.10 3/5] NFSD: Limit the number of concurrent async COPY operations Date: Tue, 19 Nov 2024 07:30:31 -0500 Message-ID: <20241119004732.4703-4-cel@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241119004732.4703-4-cel@kernel.org> References: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: <20241119123031.l4-MHA4JYVuap3DdQ2QFsM1a7Fm0M2ZKCjUbEsYO--8@z> [ Sasha's backport helper bot ] Hi, The upstream commit SHA1 provided is correct: aadc3bbea163b6caaaebfdd2b6c4667fbc726752 WARNING: Author mismatch between patch and upstream commit: Backport author: cel@kernel.org Commit author: Chuck Lever Commit in newer trees: |-----------------|----------------------------------------------| | 6.11.y | Present (different SHA1: 6a488ad7745b) | | 6.6.y | Not found | | 6.1.y | Not found | | 5.15.y | Not found | | 5.10.y | Not found | |-----------------|----------------------------------------------| Note: The patch differs from the upstream commit: --- --- - 2024-11-19 02:08:55.853453502 -0500 +++ /tmp/tmp.F38WP9NwZY 2024-11-19 02:08:55.847025582 -0500 @@ -1,3 +1,5 @@ +[ Upstream commit aadc3bbea163b6caaaebfdd2b6c4667fbc726752 ] + Nothing appears to limit the number of concurrent async COPY operations that clients can start. In addition, AFAICT each async COPY can copy an unlimited number of 4MB chunks, so can run for a @@ -17,6 +19,7 @@ Cc: stable@vger.kernel.org Reviewed-by: Jeff Layton +Link: https://nvd.nist.gov/vuln/detail/CVE-2024-49974 Signed-off-by: Chuck Lever --- fs/nfsd/netns.h | 1 + @@ -26,10 +29,10 @@ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h -index 238fc4e56e539..37b8bfdcfeea8 100644 +index 548422b24a7d..41c750f34473 100644 --- a/fs/nfsd/netns.h +++ b/fs/nfsd/netns.h -@@ -148,6 +148,7 @@ struct nfsd_net { +@@ -152,6 +152,7 @@ struct nfsd_net { u32 s2s_cp_cl_id; struct idr s2s_cp_stateids; spinlock_t s2s_cp_lock; @@ -38,10 +41,10 @@ /* * Version information diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c -index 231c6035602f6..9655acb407b72 100644 +index 3a445b78edd5..9718af3c2611 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c -@@ -1280,6 +1280,7 @@ static void nfs4_put_copy(struct nfsd4_copy *copy) +@@ -1244,6 +1244,7 @@ static void nfs4_put_copy(struct nfsd4_copy *copy) { if (!refcount_dec_and_test(©->refcount)) return; @@ -49,7 +52,7 @@ kfree(copy->cp_src); kfree(copy); } -@@ -1835,10 +1836,16 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, +@@ -1782,10 +1783,16 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, memcpy(©->fh, &cstate->current_fh.fh_handle, sizeof(struct knfsd_fh)); if (nfsd4_copy_is_async(copy)) { @@ -67,7 +70,7 @@ INIT_LIST_HEAD(&async_copy->copies); refcount_set(&async_copy->refcount, 1); async_copy->cp_src = kmalloc(sizeof(*async_copy->cp_src), GFP_KERNEL); -@@ -1878,7 +1885,7 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, +@@ -1824,7 +1831,7 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, } if (async_copy) cleanup_async_copy(async_copy); @@ -77,10 +80,10 @@ } diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c -index 7ade551bc0221..a49aa75bc0b79 100644 +index 18d64a9312a7..5547db4db8e6 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c -@@ -8554,6 +8554,7 @@ static int nfs4_state_create_net(struct net *net) +@@ -8088,6 +8088,7 @@ static int nfs4_state_create_net(struct net *net) spin_lock_init(&nn->client_lock); spin_lock_init(&nn->s2s_cp_lock); idr_init(&nn->s2s_cp_stateids); @@ -89,10 +92,10 @@ spin_lock_init(&nn->blocked_locks_lock); INIT_LIST_HEAD(&nn->blocked_locks_lru); diff --git a/fs/nfsd/xdr4.h b/fs/nfsd/xdr4.h -index fbdd42cde1fa5..2a21a7662e030 100644 +index a034b9b62137..15a617bece00 100644 --- a/fs/nfsd/xdr4.h +++ b/fs/nfsd/xdr4.h -@@ -713,6 +713,7 @@ struct nfsd4_copy { +@@ -574,6 +574,7 @@ struct nfsd4_copy { struct nfsd4_ssc_umount_item *ss_nsui; struct nfs_fh c_fh; nfs4_stateid stateid; @@ -100,3 +103,6 @@ }; static inline void nfsd4_copy_set_sync(struct nfsd4_copy *copy, bool sync) +-- +2.47.0 + --- Results of testing on various branches: | Branch | Patch Apply | Build Test | |---------------------------|-------------|------------| | stable/linux-5.10.y | Success | Success |