From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD7834F218; Tue, 3 Dec 2024 14:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236415; cv=none; b=HVC3EVFhXQCbo/UIIcpQfVfTIbbW9IN9hkJlfWiUZQKOAddvEAyd+tU0fxIdZkAHlNUH5bOcNIDeks36WTp2PAetqR/NAkLon6nZ3UXLOZXAWs7/OjIx+jjxuAtks14q778tBzQY+x4BCnxZFsz0JvqGT3yIWBI3oD5kBYsgWQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236415; c=relaxed/simple; bh=8Ytm1m2kBegCpt8MRjJb8spZ17fZsERWh84nZlplZSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aWRQq2vEYUAYYps5UlrljveHy90DvmhrQJsYHT7oxGpygLlnrF7ECIn34lqh5zb2CFtGGJMFDT53Kp0UwEu5k/KG2horRQw6DGWtTOXIxRlxbC+4BVwykF4IXGtTmMJeACX6gQmQP27LQrU65Z0o5XuIEQo/2x1JE+eww6HpF4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GYLhwKQS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GYLhwKQS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBA48C4CED8; Tue, 3 Dec 2024 14:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733236415; bh=8Ytm1m2kBegCpt8MRjJb8spZ17fZsERWh84nZlplZSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GYLhwKQSj+th7V6khNtkNyfwOq+2aW+F7OTU1wcCiMWgRAFOEy0RGoIlwD9bJEiwG gcxDpcXqy2mELXop0j0z11UyhJZyHkdSbaNoHb7IZF65xkCW2kKpyknjZK5asNZ9Py 9olEFATr5MqWsphCHCZrRBqftcRtNujKoG5QSUlM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Arnd Bergmann , "Borislav Petkov (AMD)" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 4.19 013/138] x86/amd_nb: Fix compile-testing without CONFIG_AMD_NB Date: Tue, 3 Dec 2024 15:30:42 +0100 Message-ID: <20241203141924.049952231@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241203141923.524658091@linuxfoundation.org> References: <20241203141923.524658091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann [ Upstream commit fce9642c765a18abd1db0339a7d832c29b68456a ] node_to_amd_nb() is defined to NULL in non-AMD configs: drivers/platform/x86/amd/hsmp/plat.c: In function 'init_platform_device': drivers/platform/x86/amd/hsmp/plat.c:165:68: error: dereferencing 'void *' pointer [-Werror] 165 | sock->root = node_to_amd_nb(i)->root; | ^~ drivers/platform/x86/amd/hsmp/plat.c:165:68: error: request for member 'root' in something not a structure or union Users of the interface who also allow COMPILE_TEST will cause the above build error so provide an inline stub to fix that. [ bp: Massage commit message. ] Signed-off-by: Arnd Bergmann Signed-off-by: Borislav Petkov (AMD) Reviewed-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20241029092329.3857004-1-arnd@kernel.org Signed-off-by: Sasha Levin --- arch/x86/include/asm/amd_nb.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/amd_nb.h b/arch/x86/include/asm/amd_nb.h index fddb6d26239f5..7957ac2a643fd 100644 --- a/arch/x86/include/asm/amd_nb.h +++ b/arch/x86/include/asm/amd_nb.h @@ -115,7 +115,10 @@ static inline bool amd_gart_present(void) #define amd_nb_num(x) 0 #define amd_nb_has_feature(x) false -#define node_to_amd_nb(x) NULL +static inline struct amd_northbridge *node_to_amd_nb(int node) +{ + return NULL; +} #define amd_gart_present(x) false #endif -- 2.43.0