From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5A4C1F4735; Tue, 3 Dec 2024 14:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236503; cv=none; b=lJWUSUPCUVy6OUL0zoCDYsdyrBLDkBzlThRJyKcB+n4d7WTpALkq07oVIPmrBLNR7x7uwzArGjp3Gs3iOBr7ev8lHR02ojur166JQnLpojxaWowJbJqxKCRyfYKoHZ339AZp5uxNVbWUvf1tTk+6uBfQmdlhQvtzNOusNAHMMf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236503; c=relaxed/simple; bh=9It3TFutqH38SJQiXYL9TbMf8OT3gd6wESj6tiJfjts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UHJNdFI7Ent9wkG7MwkJSaUCzusGWBHj38kJCIkl1WS2XlsCwkHSi5tP6qp5+JOzfaRROYynaGflcjJDmBRWNS19Wz+XZwK0dy1gEw7AKN+ORKkVmGJdMZK7LO7hUzH3CUE7MFWNC4wlH94dKbo7+gySxq/uYVh6Ys5Nh2/++gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wgN68wVJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wgN68wVJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E77B2C4CECF; Tue, 3 Dec 2024 14:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733236503; bh=9It3TFutqH38SJQiXYL9TbMf8OT3gd6wESj6tiJfjts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wgN68wVJGwv9JUEQdfsrOq2i75rV5TbFDRoaZy4GyZj7knSwEysNvL212h/Og0mDy DFwuNgWxs2MMUJnPTrWaVmih8Jgj8jUoi0WYqkGv9Z5n0TfErl2C7MIr+WJC2lgvFr oARvb9MNNyGbHSkYaoz8ldii1QQVkvPwS/+wA788= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dmitry Baryshkov , Jinjie Ruan , Philipp Zabel , Sasha Levin Subject: [PATCH 4.19 039/138] drm/imx/ipuv3: Use IRQF_NO_AUTOEN flag in request_irq() Date: Tue, 3 Dec 2024 15:31:08 +0100 Message-ID: <20241203141925.053113999@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241203141923.524658091@linuxfoundation.org> References: <20241203141923.524658091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit 40004709a3d3b07041a473a163ca911ef04ab8bd ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 47b1be5c0f4e ("staging: imx/drm: request irq only after adding the crtc") Reviewed-by: Dmitry Baryshkov Signed-off-by: Jinjie Ruan Reviewed-by: Philipp Zabel Link: https://patchwork.freedesktop.org/patch/msgid/20240912083020.3720233-4-ruanjinjie@huawei.com Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/imx/ipuv3-crtc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c index 824c90dca7306..0bd1f9903f1aa 100644 --- a/drivers/gpu/drm/imx/ipuv3-crtc.c +++ b/drivers/gpu/drm/imx/ipuv3-crtc.c @@ -389,14 +389,12 @@ static int ipu_crtc_init(struct ipu_crtc *ipu_crtc, } ipu_crtc->irq = ipu_plane_irq(ipu_crtc->plane[0]); - ret = devm_request_irq(ipu_crtc->dev, ipu_crtc->irq, ipu_irq_handler, 0, - "imx_drm", ipu_crtc); + ret = devm_request_irq(ipu_crtc->dev, ipu_crtc->irq, ipu_irq_handler, + IRQF_NO_AUTOEN, "imx_drm", ipu_crtc); if (ret < 0) { dev_err(ipu_crtc->dev, "irq request failed with %d.\n", ret); goto err_put_plane1_res; } - /* Only enable IRQ when we actually need it to trigger work. */ - disable_irq(ipu_crtc->irq); return 0; -- 2.43.0