From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E931B3BB24; Tue, 3 Dec 2024 14:38:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236717; cv=none; b=q9Qb9+3G4jOVRH1cFHXzeusUaBkvsuvBfmxc7KRS8axI+NyXbMSoDBe3BIMaGdgoyYd+/UjO71s8ZReZOa5m+Wr9QM7Vncmd6fPVGmIbMrRk3to07afJ+YBkQBn20byeT0GGZIhTGua1GiJqwf77Lf8wYBdOgJeZCD7JfeVEo5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236717; c=relaxed/simple; bh=t/4azxRnvRYN1nlPqcWOvKLAie6eAZUEttMXQSR4pb4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JmCk4M1pn4JBSN94ilJhpbftD1DQpAwFilXONhN0kKG5FOfi6qKrClE629mAZ+3AMkP240CNCA0xJzmYfVgAS5PiDb6XDYWQ1682Rq8zKxgUN5ZRsVzr8CHiXsRmEVRpxqj/x3VuE2eTWM7f1FWg8BpQGeRe0XAC5bKVwjOeIxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=V+qPqeSo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="V+qPqeSo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 561F4C4CECF; Tue, 3 Dec 2024 14:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733236716; bh=t/4azxRnvRYN1nlPqcWOvKLAie6eAZUEttMXQSR4pb4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V+qPqeSoEFEDT6AAbuAfpDoSSTqzBRgAwfmhbkEpsuaO3vCkhmabJavKe72LGc6SB ZRKPnMgO09eY8uxjJaenbqFRWQWsXMnxGRdP70EArutmlZCmyG+5K9Yhk8EAt5gW2J QPnkZgHljtaxwBaU1VIHREgTYMZGog6S8nKaUMs4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zeng Heng , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 066/138] scsi: fusion: Remove unused variable rc Date: Tue, 3 Dec 2024 15:31:35 +0100 Message-ID: <20241203141926.084185059@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241203141923.524658091@linuxfoundation.org> References: <20241203141923.524658091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zeng Heng [ Upstream commit bd65694223f7ad11c790ab63ad1af87a771192ee ] The return value of scsi_device_reprobe() is currently ignored in _scsih_reprobe_lun(). Fixing the calling code to deal with the potential error is non-trivial, so for now just WARN_ON(). The handling of scsi_device_reprobe()'s return value refers to _scsih_reprobe_lun() and the following link: https://lore.kernel.org/all/094fdbf57487af4f395238c0525b2a560c8f68f0.1469766027.git.calvinowens@fb.com/ Fixes: f99be43b3024 ("[SCSI] fusion: power pc and miscellaneous bug fixs") Signed-off-by: Zeng Heng Link: https://lore.kernel.org/r/20241024084417.154655-1-zengheng4@huawei.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/message/fusion/mptsas.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c index b8cf2658649ee..7c8924dff17ff 100644 --- a/drivers/message/fusion/mptsas.c +++ b/drivers/message/fusion/mptsas.c @@ -4206,10 +4206,8 @@ mptsas_find_phyinfo_by_phys_disk_num(MPT_ADAPTER *ioc, u8 phys_disk_num, static void mptsas_reprobe_lun(struct scsi_device *sdev, void *data) { - int rc; - sdev->no_uld_attach = data ? 1 : 0; - rc = scsi_device_reprobe(sdev); + WARN_ON(scsi_device_reprobe(sdev)); } static void -- 2.43.0