From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 021651F755F; Tue, 3 Dec 2024 14:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236631; cv=none; b=nhMvR8A1arP1Xd25WfUlvXKyjpYnzt1MLQ8BmG/CtC2PlttWDtZf+Lgc4WUCkMpPSspmyJEropKz/tVcXLpbqqa5IPIWos+GnEfVhlUHqoVpeyu7ehRrJ+czaKet1a0BAs6+PgbciF48lVtJSGULfK3NIl9I75GV/Aa/zzvNCxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236631; c=relaxed/simple; bh=6FBj0KtLCnGvuB6ZqlO05bUJ/Zf+SsH3MjaKflV70H4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c06/V+nUCOXgR4TgRxXRofTbfx98TrflRQ/Z9UgDd06HcpHUmedEOMkczKlyC4fYee/hDuh8POE9hg6HO909qHjpKxiO+q/WqPvtqDYFnWEl/p+Ql+qI9NKb72GT96MyD5wAeAtEf3feBLOCgjb0ZyVB6TXgA/qklHXCUTJIEX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TTxKsLbv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TTxKsLbv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A08DC4CED9; Tue, 3 Dec 2024 14:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733236630; bh=6FBj0KtLCnGvuB6ZqlO05bUJ/Zf+SsH3MjaKflV70H4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TTxKsLbvBkcCkr1klCgiReWGhvtWRBheZUzSKq3PaMe0bYMWwiEwDXhNbuxWIKanY RkLQbfgSnMYwpYSP9s4yL2/djYHu0K48rqOUcqb8ZjoWN4AFcRDfcXETdarvqdQDeB rWbTvijvLlbBDg1/JsilYibJZRatrTZWizJQdoc4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nuno Sa , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 075/138] clk: clk-axi-clkgen: make sure to enable the AXI bus clock Date: Tue, 3 Dec 2024 15:31:44 +0100 Message-ID: <20241203141926.434427635@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241203141923.524658091@linuxfoundation.org> References: <20241203141923.524658091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nuno Sa [ Upstream commit c64ef7e4851d1a9abbb7f7833e4936973ac5ba79 ] In order to access the registers of the HW, we need to make sure that the AXI bus clock is enabled. Hence let's increase the number of clocks by one. In order to keep backward compatibility and make sure old DTs still work we check if clock-names is available or not. If it is, then we can disambiguate between really having the AXI clock or a parent clock and so we can enable the bus clock. If not, we fallback to what was done before and don't explicitly enable the AXI bus clock. Note that if clock-names is given, the axi clock must be the last one in the phandle array (also enforced in the DT bindings) so that we can reuse as much code as possible. Fixes: 0e646c52cf0e ("clk: Add axi-clkgen driver") Signed-off-by: Nuno Sa Link: https://lore.kernel.org/r/20241029-axi-clkgen-fix-axiclk-v2-2-bc5e0733ad76@analog.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/clk-axi-clkgen.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-axi-clkgen.c b/drivers/clk/clk-axi-clkgen.c index 7289da51b74f1..f1e276ce28d46 100644 --- a/drivers/clk/clk-axi-clkgen.c +++ b/drivers/clk/clk-axi-clkgen.c @@ -9,6 +9,7 @@ */ #include +#include #include #include #include @@ -414,6 +415,7 @@ static int axi_clkgen_probe(struct platform_device *pdev) struct clk_init_data init; const char *parent_names[2]; const char *clk_name; + struct clk *axi_clk; unsigned int i; int ret; @@ -433,8 +435,24 @@ static int axi_clkgen_probe(struct platform_device *pdev) return PTR_ERR(axi_clkgen->base); init.num_parents = of_clk_get_parent_count(pdev->dev.of_node); - if (init.num_parents < 1 || init.num_parents > 2) - return -EINVAL; + + axi_clk = devm_clk_get_enabled(&pdev->dev, "s_axi_aclk"); + if (!IS_ERR(axi_clk)) { + if (init.num_parents < 2 || init.num_parents > 3) + return -EINVAL; + + init.num_parents -= 1; + } else { + /* + * Legacy... So that old DTs which do not have clock-names still + * work. In this case we don't explicitly enable the AXI bus + * clock. + */ + if (PTR_ERR(axi_clk) != -ENOENT) + return PTR_ERR(axi_clk); + if (init.num_parents < 1 || init.num_parents > 2) + return -EINVAL; + } for (i = 0; i < init.num_parents; i++) { parent_names[i] = of_clk_get_parent_name(pdev->dev.of_node, i); -- 2.43.0