From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB2F17BB16; Tue, 3 Dec 2024 14:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236829; cv=none; b=sb96vWLr3MlFYsJsh4FSwrtm9bS2XVLgMAhrfpP895Qa1PoaPd6JshDK0AHsYFPe8inQTHgz7OCLqKvOahpij46GVWmrPRh9V2LhEuMUWBSthSnDsf8yml+AnuMgjwEe4oS0QkmizDwzPKZdS3yR5cQq5AV7DCDPzyN5xijoyPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236829; c=relaxed/simple; bh=PohP6AqhYO9+QtbcCMAisANGT8uc1HalEagQOqUky7Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YB3rOvETV0cIKkdLLcMdAEEqX1qhyPIAXJr4WpV8q0xqLpkGs0omujBADnT1CXu7/sVb4z9w5zMsmiFEYsnYUsXUjaPLM8HjTmn3NmPxWh0vhzqnnqr7evWSvv1FPcsqFPbiT5LvZ/AzZpXVbTzO5S3pX6XynJaGpjbyDapWVX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zOtk9r7S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zOtk9r7S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A702CC4CED9; Tue, 3 Dec 2024 14:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733236829; bh=PohP6AqhYO9+QtbcCMAisANGT8uc1HalEagQOqUky7Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zOtk9r7SL5g4X3F9bz8r7KyWFgLjvdgtFQGV1LLivVyqCck5wKcxUpEDHy1KxpIEr ViCTkghqA1I7GXGWhEJz2aMv3Mt1t4UMrrEQJ2m1hVjDD7WeyOuEUe3wjM+g2En17S dZAm8rbS2t/4CDMJ34bIeVJIBVOFpoBuDEdci7Po= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Erkun , Trond Myklebust , Sasha Levin Subject: [PATCH 4.19 128/138] NFSv4.0: Fix a use-after-free problem in the asynchronous open() Date: Tue, 3 Dec 2024 15:32:37 +0100 Message-ID: <20241203141928.462920411@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241203141923.524658091@linuxfoundation.org> References: <20241203141923.524658091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Trond Myklebust [ Upstream commit 2fdb05dc0931250574f0cb0ebeb5ed8e20f4a889 ] Yang Erkun reports that when two threads are opening files at the same time, and are forced to abort before a reply is seen, then the call to nfs_release_seqid() in nfs4_opendata_free() can result in a use-after-free of the pointer to the defunct rpc task of the other thread. The fix is to ensure that if the RPC call is aborted before the call to nfs_wait_on_sequence() is complete, then we must call nfs_release_seqid() in nfs4_open_release() before the rpc_task is freed. Reported-by: Yang Erkun Fixes: 24ac23ab88df ("NFSv4: Convert open() into an asynchronous RPC call") Reviewed-by: Yang Erkun Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- fs/nfs/nfs4proc.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index c9db9a0fc7337..66db81a90ceee 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2379,12 +2379,14 @@ static void nfs4_open_release(void *calldata) struct nfs4_opendata *data = calldata; struct nfs4_state *state = NULL; + /* In case of error, no cleanup! */ + if (data->rpc_status != 0 || !data->rpc_done) { + nfs_release_seqid(data->o_arg.seqid); + goto out_free; + } /* If this request hasn't been cancelled, do nothing */ if (!data->cancelled) goto out_free; - /* In case of error, no cleanup! */ - if (data->rpc_status != 0 || !data->rpc_done) - goto out_free; /* In case we need an open_confirm, no cleanup! */ if (data->o_res.rflags & NFS4_OPEN_RESULT_CONFIRM) goto out_free; -- 2.43.0