public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: David Sterba <dsterba@suse.com>,
	stable@vger.kernel.org, linux-btrfs@vger.kernel.org,
	git@atemu.net, Luca Stefani <luca.stefani.ge1@gmail.com>
Subject: Re: [PATCH 6.6.x] btrfs: add cancellation points to trim loops
Date: Tue, 3 Dec 2024 16:41:59 +0100	[thread overview]
Message-ID: <20241203154159.GB31418@suse.cz> (raw)
In-Reply-To: <20241203152756.GA31418@suse.cz>

On Tue, Dec 03, 2024 at 04:27:56PM +0100, David Sterba wrote:
> On Mon, Dec 02, 2024 at 12:15:54PM +0100, Greg KH wrote:
> > On Mon, Nov 25, 2024 at 07:07:28PM +0100, David Sterba wrote:
> > > From: Luca Stefani <luca.stefani.ge1@gmail.com>
> > > 
> > > There are reports that system cannot suspend due to running trim because
> > > the task responsible for trimming the device isn't able to finish in
> > > time, especially since we have a free extent discarding phase, which can
> > > trim a lot of unallocated space. There are no limits on the trim size
> > > (unlike the block group part).
> > > 
> > > Since trime isn't a critical call it can be interrupted at any time,
> > > in such cases we stop the trim, report the amount of discarded bytes and
> > > return an error.
> > > 
> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=219180
> > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1229737
> > > CC: stable@vger.kernel.org # 5.15+
> > > Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
> > > Reviewed-by: David Sterba <dsterba@suse.com>
> > > Signed-off-by: David Sterba <dsterba@suse.com>
> > > ---
> > 
> > No git id?  :(
> 
> I forgot to add it but meanwhile Sasha looked up the commit and added it for me.

For the record it's 69313850dce33ce8c24b38576a279421f4c60996

  reply	other threads:[~2024-12-03 15:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 18:07 [PATCH 6.6.x] btrfs: add cancellation points to trim loops David Sterba
2024-11-25 18:14 ` kernel test robot
2024-11-25 18:59 ` Sasha Levin
2024-12-02 11:15 ` Greg KH
2024-12-03 15:27   ` David Sterba
2024-12-03 15:41     ` David Sterba [this message]
2024-12-06 12:37       ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2024-12-06 16:01 David Sterba
2024-12-06 23:11 ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241203154159.GB31418@suse.cz \
    --to=dsterba@suse.cz \
    --cc=dsterba@suse.com \
    --cc=git@atemu.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=luca.stefani.ge1@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox