From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE0B122C6EB; Wed, 4 Dec 2024 17:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733331827; cv=none; b=Bso3q+5HDOauBW77rZbEF2o0Tn4LW7a37xn1X0iVrOpBCNF0a6Z7Zx5RlXKtK1fbSulAU7dXKvplFjq4B3gW5a1Q0eR7+dxgPSiCvLenVkq35Ai2aq2+oqf6riPdPR8niVhx5vobUZjAU4spwaHyHjHRVbVR2cBq2WzqOZfY+q8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733331827; c=relaxed/simple; bh=+GM8meK9bVXhzo7DXqwHhbJ0G6FRwNT3ZH5GEpWDOJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DF8mUoEqa/8nl7VR5CkAxaitXZQITOywYXKLISAC4n/mozIIy6iQynysLV+J0PWehd3ugWL2KNVxeRRhK3yxslSbpO2rOdQELcsJJfW7hIzc6q1VbnEBEhU+TYQZoTWFEJe9Y4QpuwbiMxG61iQChtpnQZfMvepf2szCMniXIQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=URhfmTu8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="URhfmTu8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF9A1C4CECD; Wed, 4 Dec 2024 17:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733331827; bh=+GM8meK9bVXhzo7DXqwHhbJ0G6FRwNT3ZH5GEpWDOJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=URhfmTu8LNswKq2bfr9anScEiwSat66RL+L2f4WTGdUisS9+LRIHCc0XB/8arw3+B 1m0zRFV0RrnbwIYuSS/PRajjRXgoEq3D45QK+VcTHYR11O1mPRw6CPGU5SpfcMbSYp Ox4ZFDNsBoBRt7sqvxxwS1wQin6rn6a/Dn/A4ssxjNKfV25KnkYrzDewYMkW+M8hZZ 9haW/iW3UKtoSqyNhpmg50d3J8WGExxcWaBJS0bGdO5fnHbVUDJcdl/Von26/P3lwN rBM+KaFI20QY0BeUhlocDno5n1FYnUGxUrqjDCBvCGdbO8JAsF1EXRl+BhK147GFQE EE+ZJC+D7MNkg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andre Przywara , Chen-Yu Tsai , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.19 2/6] mfd: axp20x: Allow multiple regulators Date: Wed, 4 Dec 2024 10:52:21 -0500 Message-ID: <20241204155226.2215336-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241204155226.2215336-1-sashal@kernel.org> References: <20241204155226.2215336-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.324 Content-Transfer-Encoding: 8bit From: Andre Przywara [ Upstream commit e37ec32188701efa01455b9be42a392adab06ce4 ] At the moment trying to register a second AXP chip makes the probe fail, as some sysfs registration fails due to a duplicate name: ... [ 3.688215] axp20x-i2c 0-0035: AXP20X driver loaded [ 3.695610] axp20x-i2c 0-0036: AXP20x variant AXP323 found [ 3.706151] sysfs: cannot create duplicate filename '/bus/platform/devices/axp20x-regulator' [ 3.714718] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-rc1-00026-g50bf2e2c079d-dirty #192 [ 3.724020] Hardware name: Avaota A1 (DT) [ 3.728029] Call trace: [ 3.730477] dump_backtrace+0x94/0xec [ 3.734146] show_stack+0x18/0x24 [ 3.737462] dump_stack_lvl+0x80/0xf4 [ 3.741128] dump_stack+0x18/0x24 [ 3.744444] sysfs_warn_dup+0x64/0x80 [ 3.748109] sysfs_do_create_link_sd+0xf0/0xf8 [ 3.752553] sysfs_create_link+0x20/0x40 [ 3.756476] bus_add_device+0x64/0x104 [ 3.760229] device_add+0x310/0x760 [ 3.763717] platform_device_add+0x10c/0x238 [ 3.767990] mfd_add_device+0x4ec/0x5c8 [ 3.771829] mfd_add_devices+0x88/0x11c [ 3.775666] axp20x_device_probe+0x70/0x184 [ 3.779851] axp20x_i2c_probe+0x9c/0xd8 ... This is because we use PLATFORM_DEVID_NONE for the mfd_add_devices() call, which would number the child devices in the same 0-based way, even for the second (or any other) instance. Use PLATFORM_DEVID_AUTO instead, which automatically assigns non-conflicting device numbers. Signed-off-by: Andre Przywara Reviewed-by: Chen-Yu Tsai Link: https://lore.kernel.org/r/20241007001408.27249-4-andre.przywara@arm.com Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/axp20x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index dcb341d627582..f5ca5989a3c7f 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -954,7 +954,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x) return ret; } - ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells, + ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_AUTO, axp20x->cells, axp20x->nr_cells, NULL, 0, NULL); if (ret) { -- 2.43.0