From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2352066EE; Wed, 4 Dec 2024 23:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733354966; cv=none; b=fKx2W/Dj7TXM6/ob0r6/8kgknaN+zoRMxXJahSKRHzSY9CTYF4QUs5WAI3rsk6FmxQtxrwT192IlIJX2fTBkiyxqFY/ieml5xdCsLmVHSwPmPM7Gbw8VpRFHGNzMIUkac3GFFXJMYqyLLQ+FC9upyURWPm7UAcvtf+cW7H6M0Tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733354966; c=relaxed/simple; bh=x8eRW3pEg73F7xpBjVgbALIemjr5m5Id5xmnK9233ao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tq76FKcn3JjFF2rCnnXLS4xmqvzYPNdj48PX6V2NxZ8dF1nE/xxLfDISgik+WbAJ+BEVP6wloezcgJhmwXTAlDM4E42ZMABcPHj88pcC7TAMqissgQXZmAQLJ0Th90peNGlK8IlhReyD94QfAkzO6zX2VyryNDyiEveT9/HL0LE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ag+BDMl0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ag+BDMl0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A1A0C4CECD; Wed, 4 Dec 2024 23:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733354965; bh=x8eRW3pEg73F7xpBjVgbALIemjr5m5Id5xmnK9233ao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ag+BDMl0N9KrX/M1iei+qr7yCcX7roIzoHfdZpYTVNywqK8NsqbvWdKWDOu/sGpPp sMYt8xbyglqT3eFslJmvJM0KDD80dAGTSoE/DX+1T0N930SegdLSVKQtIFUiqe5kW8 /vGD3LjJpjR7B2+4wtng63+i8bAwceGrDl7u+5+Er42o/IFz8mR9gaxrxKbHwBgSyz av+qgISpchFABQ77t6oNqKk3YNKlq93x2BRzE2j1nxIuk2o2fvENAui0ib4SazWouU 7ipaaDlvs4dL7/zOQy10xgfkhXLsA9P15VeKeJvOj3Opg4EGPYUgApf1am+Sq6DfUB Dbx2k4k6WcuuQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michael Ellerman , Rob Herring , Madhavan Srinivasan , Sasha Levin , aneesh.kumar@kernel.org, jsavitz@redhat.com, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 6.11 15/15] powerpc/prom_init: Fixup missing powermac #size-cells Date: Wed, 4 Dec 2024 17:17:09 -0500 Message-ID: <20241204221726.2247988-15-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241204221726.2247988-1-sashal@kernel.org> References: <20241204221726.2247988-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.11.10 Content-Transfer-Encoding: 8bit From: Michael Ellerman [ Upstream commit cf89c9434af122f28a3552e6f9cc5158c33ce50a ] On some powermacs `escc` nodes are missing `#size-cells` properties, which is deprecated and now triggers a warning at boot since commit 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling"). For example: Missing '#size-cells' in /pci@f2000000/mac-io@c/escc@13000 WARNING: CPU: 0 PID: 0 at drivers/of/base.c:133 of_bus_n_size_cells+0x98/0x108 Hardware name: PowerMac3,1 7400 0xc0209 PowerMac ... Call Trace: of_bus_n_size_cells+0x98/0x108 (unreliable) of_bus_default_count_cells+0x40/0x60 __of_get_address+0xc8/0x21c __of_address_to_resource+0x5c/0x228 pmz_init_port+0x5c/0x2ec pmz_probe.isra.0+0x144/0x1e4 pmz_console_init+0x10/0x48 console_init+0xcc/0x138 start_kernel+0x5c4/0x694 As powermacs boot via prom_init it's possible to add the missing properties to the device tree during boot, avoiding the warning. Note that `escc-legacy` nodes are also missing `#size-cells` properties, but they are skipped by the macio driver, so leave them alone. Depends-on: 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling") Signed-off-by: Michael Ellerman Reviewed-by: Rob Herring Signed-off-by: Madhavan Srinivasan Link: https://patch.msgid.link/20241126025710.591683-1-mpe@ellerman.id.au Signed-off-by: Sasha Levin --- arch/powerpc/kernel/prom_init.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index fbb68fc28ed3a..935568d68196d 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -2932,7 +2932,7 @@ static void __init fixup_device_tree_chrp(void) #endif #if defined(CONFIG_PPC64) && defined(CONFIG_PPC_PMAC) -static void __init fixup_device_tree_pmac(void) +static void __init fixup_device_tree_pmac64(void) { phandle u3, i2c, mpic; u32 u3_rev; @@ -2972,7 +2972,31 @@ static void __init fixup_device_tree_pmac(void) &parent, sizeof(parent)); } #else -#define fixup_device_tree_pmac() +#define fixup_device_tree_pmac64() +#endif + +#ifdef CONFIG_PPC_PMAC +static void __init fixup_device_tree_pmac(void) +{ + __be32 val = 1; + char type[8]; + phandle node; + + // Some pmacs are missing #size-cells on escc nodes + for (node = 0; prom_next_node(&node); ) { + type[0] = '\0'; + prom_getprop(node, "device_type", type, sizeof(type)); + if (prom_strcmp(type, "escc")) + continue; + + if (prom_getproplen(node, "#size-cells") != PROM_ERROR) + continue; + + prom_setprop(node, NULL, "#size-cells", &val, sizeof(val)); + } +} +#else +static inline void fixup_device_tree_pmac(void) { } #endif #ifdef CONFIG_PPC_EFIKA @@ -3197,6 +3221,7 @@ static void __init fixup_device_tree(void) fixup_device_tree_maple_memory_controller(); fixup_device_tree_chrp(); fixup_device_tree_pmac(); + fixup_device_tree_pmac64(); fixup_device_tree_efika(); fixup_device_tree_pasemi(); } -- 2.43.0