From: Oleg Nesterov <oleg@redhat.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, Ard Biesheuvel <ardb@kernel.org>,
Uros Bizjak <ubizjak@gmail.com>,
stable@vger.kernel.org, Fangrui Song <i@maskray.me>,
Nathan Chancellor <nathan@kernel.org>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v5 01/16] x86/stackprotector: Work around strict Clang TLS symbol requirements
Date: Fri, 6 Dec 2024 12:51:54 +0100 [thread overview]
Message-ID: <20241206115154.GA32491@redhat.com> (raw)
In-Reply-To: <20241105155801.1779119-2-brgerst@gmail.com>
On 11/05, Brian Gerst wrote:
>
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -468,6 +468,9 @@ SECTIONS
> . = ASSERT((_end - LOAD_OFFSET <= KERNEL_IMAGE_SIZE),
> "kernel image bigger than KERNEL_IMAGE_SIZE");
>
> +/* needed for Clang - see arch/x86/entry/entry.S */
> +PROVIDE(__ref_stack_chk_guard = __stack_chk_guard);
Don't we need the simple fix below?
without this patch I can't build the kernel with CONFIG_STACKPROTECTOR=n.
Oleg.
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index fab3ac9a4574..2ff48645bab9 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -472,8 +472,10 @@ SECTIONS
. = ASSERT((_end - LOAD_OFFSET <= KERNEL_IMAGE_SIZE),
"kernel image bigger than KERNEL_IMAGE_SIZE");
+#ifdef CONFIG_STACKPROTECTOR
/* needed for Clang - see arch/x86/entry/entry.S */
PROVIDE(__ref_stack_chk_guard = __stack_chk_guard);
+#endif
#ifdef CONFIG_X86_64
/*
next prev parent reply other threads:[~2024-12-06 11:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241105155801.1779119-1-brgerst@gmail.com>
2024-11-05 15:57 ` [PATCH v5 01/16] x86/stackprotector: Work around strict Clang TLS symbol requirements Brian Gerst
2024-11-05 19:30 ` Nathan Chancellor
2024-11-08 14:43 ` [tip: x86/urgent] " tip-bot2 for Ard Biesheuvel
2024-12-06 11:51 ` Oleg Nesterov [this message]
2024-12-06 14:09 ` [PATCH v5 01/16] " Brian Gerst
2024-12-06 14:28 ` Oleg Nesterov
2024-12-06 12:32 ` [PATCH] x86/stackprotector: fix build failure with CONFIG_STACKPROTECTOR=n Oleg Nesterov
2024-12-06 13:17 ` Ard Biesheuvel
2024-12-06 14:21 ` Oleg Nesterov
2024-12-06 14:37 ` Ard Biesheuvel
2024-12-06 15:12 ` Brian Gerst
2024-12-06 15:17 ` Ard Biesheuvel
2025-03-10 21:44 ` Borislav Petkov
2025-03-10 22:19 ` Ard Biesheuvel
2025-03-11 10:23 ` Borislav Petkov
2025-03-11 10:37 ` Ard Biesheuvel
2025-03-11 11:21 ` Borislav Petkov
2025-03-11 13:13 ` Borislav Petkov
2025-03-11 14:37 ` Oleg Nesterov
2025-03-11 17:46 ` Borislav Petkov
2025-03-11 18:10 ` Oleg Nesterov
2025-03-11 19:01 ` Borislav Petkov
2025-03-11 19:24 ` Oleg Nesterov
2025-03-11 21:27 ` Brian Gerst
2025-03-11 21:42 ` Oleg Nesterov
2025-03-11 21:47 ` Brian Gerst
2025-03-12 9:28 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206115154.GA32491@redhat.com \
--to=oleg@redhat.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=i@maskray.me \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=nathan@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox