From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73EF714A4F0; Fri, 6 Dec 2024 14:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733496014; cv=none; b=OCgrMKL/i/vMgQJUM6V4EaeD1Yn5ec77ZT8TnbaNifVcM4GajaHtg501SyOG0CVKfNHZEAJNXZNqJDSF2P29rPrzxnFCOXrvivG8KdAECFt3bUCjlQWXLbNz2azogy3IDqbC+efn9r5yD+67lTGWxevooCoBEkeJPRXuYeuGeOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733496014; c=relaxed/simple; bh=hIJX3LPTd+RxSEntcfbH/oA+VMRY6zlwEVuBH3Be0Y8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B4lcbU5ppc9JbMBblvdNQqMGcKfNhHczD6BHg8dZ4OPP67qMwuwxTuf7zkoeumF4UQlAxvOqrP1Nu1QxougcNKHo926fw1LkIrRlFED0R9UJMtEj4MicDxLW7YdZRH9L26rkpubHic7gQ3o+tFn+xcpVV8xRKYUi07BpY6JpUJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d3TSp5KA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d3TSp5KA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7525C4CEDC; Fri, 6 Dec 2024 14:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733496014; bh=hIJX3LPTd+RxSEntcfbH/oA+VMRY6zlwEVuBH3Be0Y8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d3TSp5KAGhHeY4CuGvfkOrt1MLohD1rzh5Z1mu0I0yvicyCUsC/oSsEcwcbOsw39w 3RR5ykZdTDmjd/IfFfps2bnAmM98RSPEghouQKJdmHm/S1jj2wNs4213DyIIjLwMxa +xaFjzB7hReQKQJCVM31UiA64aBbYtdw036X9Kiw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Benjamin Gaignard , Nicolas Dufresne , Hans Verkuil Subject: [PATCH 6.12 028/146] media: verisilicon: av1: Fix reference video buffer pointer assignment Date: Fri, 6 Dec 2024 15:35:59 +0100 Message-ID: <20241206143528.749300748@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241206143527.654980698@linuxfoundation.org> References: <20241206143527.654980698@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Benjamin Gaignard commit 672f24ed6ebcd986688c6674a6d994a265fefc25 upstream. Always get new destination buffer for reference frame because nothing garantees the one set previously is still valid or unused. Fixes this chromium test suite: https://chromium.googlesource.com/chromium/src/media/+/refs/heads/main/test/data/test-25fps.av1.ivf Fixes: 727a400686a2 ("media: verisilicon: Add Rockchip AV1 decoder") Cc: Signed-off-by: Benjamin Gaignard Reviewed-by: Nicolas Dufresne Signed-off-by: Hans Verkuil [hverkuil: fix typo and add link to chromium test suite] Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c +++ b/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c @@ -161,8 +161,7 @@ static int rockchip_vpu981_av1_dec_frame av1_dec->frame_refs[i].timestamp = timestamp; av1_dec->frame_refs[i].frame_type = frame->frame_type; av1_dec->frame_refs[i].order_hint = frame->order_hint; - if (!av1_dec->frame_refs[i].vb2_ref) - av1_dec->frame_refs[i].vb2_ref = hantro_get_dst_buf(ctx); + av1_dec->frame_refs[i].vb2_ref = hantro_get_dst_buf(ctx); for (j = 0; j < V4L2_AV1_TOTAL_REFS_PER_FRAME; j++) av1_dec->frame_refs[i].order_hints[j] = frame->order_hints[j];