From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92AFF1442E8; Fri, 6 Dec 2024 14:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733496829; cv=none; b=F2iT/okdN2Skb/zQhXPXtyLnLW0uFgN+dTkTOvaVt3xmgEcNKGUMWg4eHmYbqXJrlllGR6G0CbTWi/5fnUkC1oUrFMqMQizzocW/XXoffcppdUz7UWhx9CwtAH42QmzMoJKeZxA3u653hkQ0hkTzpV5+ityq6Cu+hI11CMNtqAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733496829; c=relaxed/simple; bh=DQ25seaOarU9yhHKsqs63wspxVh8L8rl3QxEoCoHeQk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DSdDSoiBQg06vLb1/PwkzNni9CFPYLo4UtGsHWCzZ/pgXmsz8sWvSLHZ10Q4JpaopdLifQW0eiCldztFWWU1l4E/J2qSqxzGxutjIDvI+aHp4YznpojHfHhILkzLCfjqekDx+LqFSnmakbxLBN4xl6mf2CR7lkJas3m7kzs89oU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NPAOKtQI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NPAOKtQI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18731C4CED1; Fri, 6 Dec 2024 14:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733496829; bh=DQ25seaOarU9yhHKsqs63wspxVh8L8rl3QxEoCoHeQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NPAOKtQIWSjZnXqxaKd3bMTHkyHgKrFqsgm9PrwHcKYRIL1q9Xy1hQw+51zwJis0K 7UjDnUggHGSlh0IVisJWyxey/07Uezww3uZrTalT0Sa6UKkQ9jKf8raNqJ0FZ6zWot ojrzXJDIwzgddrBqvTruEW3H/e7tWcz/eh8ougPc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.6 118/676] soc: qcom: geni-se: fix array underflow in geni_se_clk_tbl_get() Date: Fri, 6 Dec 2024 15:28:57 +0100 Message-ID: <20241206143657.965649269@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241206143653.344873888@linuxfoundation.org> References: <20241206143653.344873888@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 78261cb08f06c93d362cab5c5034bf5899bc7552 ] This loop is supposed to break if the frequency returned from clk_round_rate() is the same as on the previous iteration. However, that check doesn't make sense on the first iteration through the loop. It leads to reading before the start of these->clk_perf_tbl[] array. Fixes: eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/8cd12678-f44a-4b16-a579-c8f11175ee8c@stanley.mountain Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/soc/qcom/qcom-geni-se.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c index ba788762835fa..e339253ccba86 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -586,7 +586,8 @@ int geni_se_clk_tbl_get(struct geni_se *se, unsigned long **tbl) for (i = 0; i < MAX_CLK_PERF_LEVEL; i++) { freq = clk_round_rate(se->clk, freq + 1); - if (freq <= 0 || freq == se->clk_perf_tbl[i - 1]) + if (freq <= 0 || + (i > 0 && freq == se->clk_perf_tbl[i - 1])) break; se->clk_perf_tbl[i] = freq; } -- 2.43.0