From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD6E353A7; Fri, 6 Dec 2024 15:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733498371; cv=none; b=Vaxlwia9EufmmQ5tnwVppseBfQwc6S02WNsjpW4s2MChOJTJENTHlZ6Oppr5XOGb8USjdxBaczrqMvBZNl3VXVUVutMjy4CXbUboqkC/hL/F0YYUJZBPvBxRrpn93R1dqHEvqqm6uxp7E39zOvZGYxS+VLuUBHBnp7Ph5v9kvGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733498371; c=relaxed/simple; bh=W4dFHMaFGxnLEHPhzh48H+FpxAYCRGalpeKNFcYyTCo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ahqYQvR/d1l7yl1IJ2omY/IM7b5vNX7cR0YTmrR4fBtoksEJbbtjmrQBxkMWlLjc1VGExt2raRPTzUGquNwrP7vu1Cm6wgVX03NV0gPOyvFGORT/prcOrz9QYLtMPAcFwgW8aTm6wCDbQvS4NlmxikqwK+vb57m2oB8BdxkBChA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1DUVVCvT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1DUVVCvT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E09EC4CED1; Fri, 6 Dec 2024 15:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733498371; bh=W4dFHMaFGxnLEHPhzh48H+FpxAYCRGalpeKNFcYyTCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1DUVVCvTcEj4vsP3LsHELbo+3hVFOI02fDs0nr0C//ZTXg4Y56/FB2j+Zwai5FMvs q0cZu1TK0b/2TYwJijA+kbDCsJu/L9Xs3iBavsinrTMCI8PfYPSiDYZDEaAOuqrOfV M8Fn/gVOKnsNRvi1liHkvVC8XvO73nnUJcczun9w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wolfram Sang , Miquel Raynal , Alexandre Belloni , Sasha Levin Subject: [PATCH 6.6 566/676] rtc: rzn1: fix BCD to rtc_time conversion errors Date: Fri, 6 Dec 2024 15:36:25 +0100 Message-ID: <20241206143715.471186965@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241206143653.344873888@linuxfoundation.org> References: <20241206143653.344873888@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wolfram Sang [ Upstream commit 55727188dfa3572aecd946e58fab9e4a64f06894 ] tm_mon describes months from 0 to 11, but the register contains BCD from 1 to 12. tm_year contains years since 1900, but the BCD contains 20XX. Apply the offsets when converting these numbers. Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver") Signed-off-by: Wolfram Sang Reviewed-by: Miquel Raynal Link: https://lore.kernel.org/r/20241113113032.27409-1-wsa+renesas@sang-engineering.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-rzn1.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 56ebbd4d04814..8570c8e63d70c 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -111,8 +111,8 @@ static int rzn1_rtc_read_time(struct device *dev, struct rtc_time *tm) tm->tm_hour = bcd2bin(tm->tm_hour); tm->tm_wday = bcd2bin(tm->tm_wday); tm->tm_mday = bcd2bin(tm->tm_mday); - tm->tm_mon = bcd2bin(tm->tm_mon); - tm->tm_year = bcd2bin(tm->tm_year); + tm->tm_mon = bcd2bin(tm->tm_mon) - 1; + tm->tm_year = bcd2bin(tm->tm_year) + 100; return 0; } @@ -128,8 +128,8 @@ static int rzn1_rtc_set_time(struct device *dev, struct rtc_time *tm) tm->tm_hour = bin2bcd(tm->tm_hour); tm->tm_wday = bin2bcd(rzn1_rtc_tm_to_wday(tm)); tm->tm_mday = bin2bcd(tm->tm_mday); - tm->tm_mon = bin2bcd(tm->tm_mon); - tm->tm_year = bin2bcd(tm->tm_year); + tm->tm_mon = bin2bcd(tm->tm_mon + 1); + tm->tm_year = bin2bcd(tm->tm_year - 100); val = readl(rtc->base + RZN1_RTC_CTL2); if (!(val & RZN1_RTC_CTL2_STOPPED)) { -- 2.43.0