Re: [PATCH 6.6.x] btrfs: add cancellation points to trim loops

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Dec 03, 2024 at 04:41:59PM +0100, David Sterba wrote:
> On Tue, Dec 03, 2024 at 04:27:56PM +0100, David Sterba wrote:
> > On Mon, Dec 02, 2024 at 12:15:54PM +0100, Greg KH wrote:
> > > On Mon, Nov 25, 2024 at 07:07:28PM +0100, David Sterba wrote:
> > > > From: Luca Stefani <luca.stefani.ge1@gmail.com>
> > > > 
> > > > There are reports that system cannot suspend due to running trim because
> > > > the task responsible for trimming the device isn't able to finish in
> > > > time, especially since we have a free extent discarding phase, which can
> > > > trim a lot of unallocated space. There are no limits on the trim size
> > > > (unlike the block group part).
> > > > 
> > > > Since trime isn't a critical call it can be interrupted at any time,
> > > > in such cases we stop the trim, report the amount of discarded bytes and
> > > > return an error.
> > > > 
> > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=219180
> > > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1229737
> > > > CC: stable@vger.kernel.org # 5.15+
> > > > Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
> > > > Reviewed-by: David Sterba <dsterba@suse.com>
> > > > Signed-off-by: David Sterba <dsterba@suse.com>
> > > > ---
> > > 
> > > No git id?  :(
> > 
> > I forgot to add it but meanwhile Sasha looked up the commit and added it for me.
> 
> For the record it's 69313850dce33ce8c24b38576a279421f4c60996

Great, can you resend it with that information?

thanks,

greg k-h