From: Greg KH <gregkh@linuxfoundation.org>
To: Hui Wang <hui.wang@canonical.com>
Cc: stable@vger.kernel.org, linux-serial@vger.kernel.org,
hvilleneuve@dimonoff.com
Subject: Re: [stable-kernel-only][5.15.y][5.10.y][PATCH] serial: sc16is7xx: the reg needs to shift in regmap_noinc
Date: Sat, 7 Dec 2024 07:31:52 +0100 [thread overview]
Message-ID: <2024120740-violet-breath-763f@gregkh> (raw)
In-Reply-To: <20241207001225.203262-1-hui.wang@canonical.com>
On Sat, Dec 07, 2024 at 08:12:25AM +0800, Hui Wang wrote:
> Recently we found the fifo_read() and fifo_write() are broken in our
> 5.15 and 5.4 kernels after cherry-pick the commit e635f652696e
> ("serial: sc16is7xx: convert from _raw_ to _noinc_ regmap functions
> for FIFO"), that is because the reg needs to shift if we don't
> cherry-pick a prerequiste commit 3837a0379533 ("serial: sc16is7xx:
> improve regmap debugfs by using one regmap per port").
>
> Here fix it by shifting the reg as regmap_volatile() does.
>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
> drivers/tty/serial/sc16is7xx.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Why not take the proper upstream commit instead?
next prev parent reply other threads:[~2024-12-07 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-07 0:12 [stable-kernel-only][5.15.y][5.10.y][PATCH] serial: sc16is7xx: the reg needs to shift in regmap_noinc Hui Wang
2024-12-07 0:13 ` kernel test robot
2024-12-07 2:07 ` Sasha Levin
2024-12-07 6:31 ` Greg KH [this message]
2024-12-07 13:47 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024120740-violet-breath-763f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=hvilleneuve@dimonoff.com \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox