Re: [PATCH 5.15] gve: Fixes for napi_poll when budget is 0

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Dec 09, 2024 at 10:46:58AM -0800, Ziwei Xiao wrote:
> On Mon, Dec 2, 2024 at 1:46 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Nov 26, 2024 at 07:19:22PM +0000, Ziwei Xiao wrote:
> > > Netpoll will explicitly pass the polling call with a budget of 0 to
> > > indicate it's clearing the Tx path only. For the gve_rx_poll and
> > > gve_xdp_poll, they were mistakenly taking the 0 budget as the indication
> > > to do all the work. Add check to avoid the rx path and xdp path being
> > > called when budget is 0. And also avoid napi_complete_done being called
> > > when budget is 0 for netpoll.
> > >
> > > The original fix was merged here:
> > > https://lore.kernel.org/r/20231114004144.2022268-1-ziweixiao@google.com
> > > Resend it since the original one was not cleanly applied to 5.15 kernel.
> > >
> > > Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
> > > Signed-off-by: Ziwei Xiao <ziweixiao@google.com>
> > > Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
> > > Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
> > > ---
> >
> > No git id?  :(
> 
> Sorry for missing that. Here is the commit id:
> 
> commit 278a370c1766 upstream.
> 
> Do I need to resend a V2 to contain the above line? Thank you!
> 

Yes please.

thanks,

greg k-h