From: Greg KH <gregkh@linuxfoundation.org>
To: guocai.he.cn@windriver.com
Cc: juntong.deng@outlook.com, agruenba@redhat.com,
majortomtosourcecontrol@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH V2][5.15.y] gfs2: Fix slab-use-after-free in gfs2_qd_dealloc
Date: Wed, 11 Dec 2024 09:32:44 +0100 [thread overview]
Message-ID: <2024121137-devotion-overstate-a2cf@gregkh> (raw)
In-Reply-To: <20241211081023.3365559-1-guocai.he.cn@windriver.com>
On Wed, Dec 11, 2024 at 04:10:23PM +0800, guocai.he.cn@windriver.com wrote:
> From: Juntong Deng <juntong.deng@outlook.com>
>
> commit 7ad4e0a4f61c57c3ca291ee010a9d677d0199fba upstream.
>
> In gfs2_put_super(), whether withdrawn or not, the quota should
> be cleaned up by gfs2_quota_cleanup().
>
> Otherwise, struct gfs2_sbd will be freed before gfs2_qd_dealloc (rcu
> callback) has run for all gfs2_quota_data objects, resulting in
> use-after-free.
>
> Also, gfs2_destroy_threads() and gfs2_quota_cleanup() is already called
> by gfs2_make_fs_ro(), so in gfs2_put_super(), after calling
> gfs2_make_fs_ro(), there is no need to call them again.
>
> Reported-by: syzbot+29c47e9e51895928698c@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=29c47e9e51895928698c
> Signed-off-by: Juntong Deng <juntong.deng@outlook.com>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
> Signed-off-by: Guocai He <guocai.he.cn@windriver.com>
> ---
> This commit is backporting 7ad4e0a4f61c7ad4e0a4f61c57c3ca291ee010a9d677d0199fba to the branch linux-5.15.y to
> solve the CVE-2024-52760. Please merge this commit to linux-5.15.y.
What changed from v1?
next prev parent reply other threads:[~2024-12-11 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 8:10 [PATCH V2][5.15.y] gfs2: Fix slab-use-after-free in gfs2_qd_dealloc guocai.he.cn
2024-12-11 8:32 ` Greg KH [this message]
2024-12-11 16:33 ` Sasha Levin
2024-12-12 11:59 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-12-13 10:24 guocai.he.cn
2024-12-13 15:13 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024121137-devotion-overstate-a2cf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=agruenba@redhat.com \
--cc=guocai.he.cn@windriver.com \
--cc=juntong.deng@outlook.com \
--cc=majortomtosourcecontrol@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox