From: Greg KH <gregkh@linuxfoundation.org>
To: Ziwei Xiao <ziweixiao@google.com>
Cc: stable@vger.kernel.org, sashal@kernel.org,
pkaligineedi@google.com, hramamurthy@google.com
Subject: Re: [PATCH 5.15 v2] gve: Fixes for napi_poll when budget is 0
Date: Thu, 12 Dec 2024 13:00:36 +0100 [thread overview]
Message-ID: <2024121214-surplus-imitation-df99@gregkh> (raw)
In-Reply-To: <20241210235914.638427-1-ziweixiao@google.com>
On Tue, Dec 10, 2024 at 11:59:14PM +0000, Ziwei Xiao wrote:
> Netpoll will explicitly pass the polling call with a budget of 0 to
> indicate it's clearing the Tx path only. For the gve_rx_poll and
> gve_xdp_poll, they were mistakenly taking the 0 budget as the indication
> to do all the work. Add check to avoid the rx path and xdp path being
> called when budget is 0. And also avoid napi_complete_done being called
> when budget is 0 for netpoll.
>
> The original fix was merged here:
> https://lore.kernel.org/r/20231114004144.2022268-1-ziweixiao@google.com
> Resend it since the original one was not cleanly applied to 5.15 kernel.
>
> commit 278a370c1766 ("gve: Fixes for napi_poll when budget is 0")
>
> Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
> Signed-off-by: Ziwei Xiao <ziweixiao@google.com>
> Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
> Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
> ---
> Changes in v2:
> * Add the original git commit id
In the future, please add it in a way that we can figure it out (see the
hundreds of examples on the mailing list for how it is done.)
thanks,
greg k-h
prev parent reply other threads:[~2024-12-12 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 23:59 [PATCH 5.15 v2] gve: Fixes for napi_poll when budget is 0 Ziwei Xiao
2024-12-11 16:33 ` Sasha Levin
2024-12-12 12:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024121214-surplus-imitation-df99@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hramamurthy@google.com \
--cc=pkaligineedi@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox