From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC922216E2D; Thu, 12 Dec 2024 17:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025054; cv=none; b=SjZTVqvHJhXZVgC7slYyWRZH2w+4hXrmQw/PZJix5g9JFsd5BxxzQqvJ1b3Dc4rMgkeOsW0lTUmMyv4pmMJlDF3VEvnCSggtsJ0CEo/LWRXpye6ROAedMSyr1C8EW2PgR5ekecalw5BiKeZOr5YyZ5bOk9Hk/OyYDmwRpXhcOmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025054; c=relaxed/simple; bh=JAsdKWJQ/e42yQDmOd6rcblI/83G5+xbYVjpH/4J2Yk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tp5b9w5oPpLx4M38jGXovDmZOkhG/VVyK8BANylhiOi8dLDE8vAfAD+42epdCBAnoVyK/eXKDSLTyP+HeW9f/nlDHU7TvVjQe8XhAdKVpcrCg5l+wvlcP8HQPv1AUfr+ZqjcTuQ9KluyE5YjSa+wpwqiVyZ58GNEFYOWG9EcRhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PsfpRYZW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PsfpRYZW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72B33C4CECE; Thu, 12 Dec 2024 17:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734025053; bh=JAsdKWJQ/e42yQDmOd6rcblI/83G5+xbYVjpH/4J2Yk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PsfpRYZWeP33MMHgB5gWh7Xszg1jgnzPDJfgyO8mNOTjzfnJ4kvfkzr+0r6nPwWY/ IwbG19DFRjGb+vEclxmJmfvawNxXwNP39TloocLDxN4PduVuB24QHvucXNB/okAS2L NEG+6q3HC9nUsQ2HErQe7XmeRUFKAVnWKf2Sl4m8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Can , Brian Norris , Tzung-Bi Shih , Sasha Levin Subject: [PATCH 5.4 039/321] firmware: google: Unregister driver_info on failure Date: Thu, 12 Dec 2024 15:59:17 +0100 Message-ID: <20241212144231.541188905@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144229.291682835@linuxfoundation.org> References: <20241212144229.291682835@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuan Can [ Upstream commit 32b0901e141f6d4cf49d820b53eb09b88b1f72f7 ] When platform_device_register_full() returns error, the gsmi_init() returns without unregister gsmi_driver_info, fix by add missing platform_driver_unregister() when platform_device_register_full() failed. Fixes: 8942b2d5094b ("gsmi: Add GSMI commands to log S0ix info") Signed-off-by: Yuan Can Acked-by: Brian Norris Link: https://lore.kernel.org/r/20241015131344.20272-1-yuancan@huawei.com Signed-off-by: Tzung-Bi Shih Signed-off-by: Sasha Levin --- drivers/firmware/google/gsmi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c index 633997af4b09e..b25a05c56f537 100644 --- a/drivers/firmware/google/gsmi.c +++ b/drivers/firmware/google/gsmi.c @@ -898,7 +898,8 @@ static __init int gsmi_init(void) gsmi_dev.pdev = platform_device_register_full(&gsmi_dev_info); if (IS_ERR(gsmi_dev.pdev)) { printk(KERN_ERR "gsmi: unable to register platform device\n"); - return PTR_ERR(gsmi_dev.pdev); + ret = PTR_ERR(gsmi_dev.pdev); + goto out_unregister; } /* SMI access needs to be serialized */ @@ -1025,10 +1026,11 @@ static __init int gsmi_init(void) gsmi_buf_free(gsmi_dev.name_buf); dma_pool_destroy(gsmi_dev.dma_pool); platform_device_unregister(gsmi_dev.pdev); - pr_info("gsmi: failed to load: %d\n", ret); +out_unregister: #ifdef CONFIG_PM platform_driver_unregister(&gsmi_driver_info); #endif + pr_info("gsmi: failed to load: %d\n", ret); return ret; } -- 2.43.0