From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAF5B216E2D; Thu, 12 Dec 2024 17:38:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025104; cv=none; b=VcULvuQPlnjY9vKoMAeue7aB8BSnhp34tezEFL5WCOxw8REbgQir/9QdjWLlpU4oUMUs6rlhRbteT6CuuEzJdQrAoF/KwCePQ7bJn3Lo13ws6wjq12crQOHDE3ogNQgDa0Way+n9DsCu2eThVMRyElkL7DAp7JhAXfpGy2+X4z4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025104; c=relaxed/simple; bh=YmafiJ0SFHItuB1mdZ171Vr872ChoUt5GAmDbI2LeVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UvLUW9IosgjdvHKbsaaNwtMTErMJeKgvOyZ55oGQyNHe8YLhjmfgWsZMMuqWnUcIeworAHl5iAkk5xnzDqGOu58oVVuT0ciKYFSCHWJi9LkFol4ARgkf83f6Uca8yY9oXBf5148HWcR7ApKSniZBNQXk7EOfXBBq5h5QHmRUmjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JrnCSETj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JrnCSETj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53757C4CECE; Thu, 12 Dec 2024 17:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734025104; bh=YmafiJ0SFHItuB1mdZ171Vr872ChoUt5GAmDbI2LeVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JrnCSETjtvSotWwsjoXKIpaN5rBQWVn4xcwiwwrzMdNeFBehNKC/w+KjFwh0Mb5mh G8eTuNEHo7dGPkDYo5lpHAd+Hpua2ODu4sltM3D35ZavOsTI6NVvQQkvxn5IgD9Jzs Y1DvL3GAyKCXIHxnlSCb+aP2ITuRLJ/msFl84EjU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jinjie Ruan , Kalle Valo , Sasha Levin Subject: [PATCH 5.4 058/321] wifi: p54: Use IRQF_NO_AUTOEN flag in request_irq() Date: Thu, 12 Dec 2024 15:59:36 +0100 Message-ID: <20241212144232.285622111@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144229.291682835@linuxfoundation.org> References: <20241212144229.291682835@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit bcd1371bd85e560ccc9159b7747f94bfe43b77a6 ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: cd8d3d321285 ("p54spi: p54spi driver") Signed-off-by: Jinjie Ruan Signed-off-by: Kalle Valo Link: https://patch.msgid.link/20240910124314.698896-2-ruanjinjie@huawei.com Signed-off-by: Sasha Levin --- drivers/net/wireless/intersil/p54/p54spi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c index cdb57819684ae..8a9168aac7281 100644 --- a/drivers/net/wireless/intersil/p54/p54spi.c +++ b/drivers/net/wireless/intersil/p54/p54spi.c @@ -623,7 +623,7 @@ static int p54spi_probe(struct spi_device *spi) gpio_direction_input(p54spi_gpio_irq); ret = request_irq(gpio_to_irq(p54spi_gpio_irq), - p54spi_interrupt, 0, "p54spi", + p54spi_interrupt, IRQF_NO_AUTOEN, "p54spi", priv->spi); if (ret < 0) { dev_err(&priv->spi->dev, "request_irq() failed"); @@ -632,8 +632,6 @@ static int p54spi_probe(struct spi_device *spi) irq_set_irq_type(gpio_to_irq(p54spi_gpio_irq), IRQ_TYPE_EDGE_RISING); - disable_irq(gpio_to_irq(p54spi_gpio_irq)); - INIT_WORK(&priv->work, p54spi_work); init_completion(&priv->fw_comp); INIT_LIST_HEAD(&priv->tx_pending); -- 2.43.0