From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1813120A5EE; Thu, 12 Dec 2024 17:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025128; cv=none; b=rlNCl2ghBgXGEaEvBdOP0Dq9vUoQjjawxLtR4Lrqfv11xLQAyhtZz8uLomRGtp/yreM1cTzbpK3O8SvRX+Z+MLxdfszXoWq0+Liq7UnWfWDERjgSpbijY2BPsxTEkBUDy6kEUVuAjowxColBvy4Qanb8p1Ok4A9QcWZ9QCcrZqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025128; c=relaxed/simple; bh=78fKKqQKYqN0udvpG6U+rzwviHjHKZ6ZbCqa9ayCqJc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uxe7D9UtEMR1ZDfKWLPhGT+d0psMsycIor0weE93UEK1g+BxnPRmjZrgqCeWHjn15mxb5Uda6e2V8cl6hvh7blpL2A8lm5I6UKOK+wGvPP+FFrHnvxxumQsr/3jpEeqpYNgPt3W6nVMzMEBgFoJzXgMFXgjoOE7aPhrF71wV6dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iJ1S8LoU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iJ1S8LoU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92827C4CECE; Thu, 12 Dec 2024 17:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734025128; bh=78fKKqQKYqN0udvpG6U+rzwviHjHKZ6ZbCqa9ayCqJc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iJ1S8LoUz1X8CaYvTnmwYHi19ReoTRNJjiCFptcAb+v7yRWPGzWUEBgdxIJoGXgpz GzmrDDiHeZFz08JklRqp7auOw3qIOsXy2fUN8VHcqg7xkc0Qfmgj5H7OIBnUlfJkdb /Hjv5uf3Po1CQ65mdKh/AcDUZHauGPh3zqVQXt6A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shengjiu Wang , Daniel Baluta , Mark Brown , Sasha Levin Subject: [PATCH 5.4 065/321] ASoC: fsl_micfil: fix regmap_write_bits usage Date: Thu, 12 Dec 2024 15:59:43 +0100 Message-ID: <20241212144232.559060390@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144229.291682835@linuxfoundation.org> References: <20241212144229.291682835@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shengjiu Wang [ Upstream commit 06df673d20230afb0e383e39235a4fa8b9a62464 ] The last parameter 1 means BIT(0), which should be the correct BIT(X). Fixes: 47a70e6fc9a8 ("ASoC: Add MICFIL SoC Digital Audio Interface driver.") Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta Link: https://patch.msgid.link/1727424031-19551-2-git-send-email-shengjiu.wang@nxp.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_micfil.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 108063610f2f4..b5b7a341a0b63 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -592,7 +592,7 @@ static irqreturn_t micfil_isr(int irq, void *devid) regmap_write_bits(micfil->regmap, REG_MICFIL_STAT, MICFIL_STAT_CHXF(i), - 1); + MICFIL_STAT_CHXF(i)); } for (i = 0; i < MICFIL_FIFO_NUM; i++) { @@ -627,7 +627,7 @@ static irqreturn_t micfil_err_isr(int irq, void *devid) if (stat_reg & MICFIL_STAT_LOWFREQF) { dev_dbg(&pdev->dev, "isr: ipg_clk_app is too low\n"); regmap_write_bits(micfil->regmap, REG_MICFIL_STAT, - MICFIL_STAT_LOWFREQF, 1); + MICFIL_STAT_LOWFREQF, MICFIL_STAT_LOWFREQF); } return IRQ_HANDLED; -- 2.43.0