From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A728B205E2E; Thu, 12 Dec 2024 17:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025660; cv=none; b=oeK5+3097NPX34t4x1Cz23LzurqCRgBFlM3VvZfu2edNzRMLJrv2y0wWa+S1AdnHVchKQZMiNzlhijaRTixRnxJ8jy1sgqA1kKItnN5JeyLw463mYi0ANFo5D0msppuHDfDxmxhD1RR+A2+ztu8P5ImRFp4ub3twleJgw4yx2+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025660; c=relaxed/simple; bh=D/s36In1HlVmWM8h9hZrw/p/oQ/7LV55kO0SohU9gIE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M1YY87ELsYp6Q6Ug6nxGbs7msoskmJuzV0NHYnWLgYjV49qjx6Og/MrmzVF6Gu5+urtLEv6DlDGMt+90u10WR0uyPC2nBBFO3EI0UxXT4kdEw+0geyLfwRqxXF1P0D1BS5uUj8Bz/1vmSYwl8gLY6SKGGw3bW9EZuY8/uegK6Ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IofeZOqq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IofeZOqq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D26FC4CECE; Thu, 12 Dec 2024 17:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734025660; bh=D/s36In1HlVmWM8h9hZrw/p/oQ/7LV55kO0SohU9gIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IofeZOqq7wEXw/6Y5k2TF0mPElip3RtcrjeunDPrcjMLjtfV9/usYddY/OlCLNwwm FCAZOEA1G8gAxLNZu/ifANVC2quzbJXc2NcF2v4eew4npZkiN7/mBHgTwoqIzMvX6u sks/5R6IF2EbSkVILmZaZWU5lLbjLMzG0Mknz5mw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Miquel Raynal , Frank Li , Alexandre Belloni Subject: [PATCH 5.4 214/321] i3c: master: Fix miss free init_dyn_addr at i3c_master_put_i3c_addrs() Date: Thu, 12 Dec 2024 16:02:12 +0100 Message-ID: <20241212144238.432028781@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144229.291682835@linuxfoundation.org> References: <20241212144229.291682835@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Frank Li commit 3082990592f7c6d7510a9133afa46e31bbe26533 upstream. if (dev->boardinfo && dev->boardinfo->init_dyn_addr) ^^^ here check "init_dyn_addr" i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, ...) ^^^^ free "dyn_addr" Fix copy/paste error "dyn_addr" by replacing it with "init_dyn_addr". Cc: stable@kernel.org Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Reviewed-by: Miquel Raynal Signed-off-by: Frank Li Link: https://lore.kernel.org/r/20241001162608.224039-1-Frank.Li@nxp.com Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/i3c/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1263,7 +1263,7 @@ static void i3c_master_put_i3c_addrs(str I3C_ADDR_SLOT_FREE); if (dev->boardinfo && dev->boardinfo->init_dyn_addr) - i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, + i3c_bus_set_addr_slot_status(&master->bus, dev->boardinfo->init_dyn_addr, I3C_ADDR_SLOT_FREE); }