From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA0C22331E; Thu, 12 Dec 2024 17:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025675; cv=none; b=JHH1MhuwCx1wMEzlAk615bK1fDZGHlCj80HCAa5sbXEvGERe1UFfmSQVVj3yicldKWtA6/HSnqt/iKo6lsmCrHyoX/wTBrKWs52Ps8Bxld+JmrFV3tcC/akRZ7pmw98SpbMfMTXmGYCyqwsQaprkpRtkBUl4L/fMYGg+tvHqvH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025675; c=relaxed/simple; bh=XuzY1iqDcIC0uY9kXkSFopNVv+lNqQu6dgQo+MoGWcY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LMubJTGGNPzBBeOJok42vNl6KzZ4IDRJz2RDQtFLzS7JA74YPuS5NotdBgGzzzvAmOgIoKXhScLlNOK4E1R42WN43J7BUnWnI/oggR99b4kK4J0JMLhQI1Z9EOkQv/qDLR00TBoRK+5h581B/Ca8lru0pO4ZzhlORoWD6y3dffY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=I4ngO/d+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="I4ngO/d+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CC36C4CECE; Thu, 12 Dec 2024 17:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734025675; bh=XuzY1iqDcIC0uY9kXkSFopNVv+lNqQu6dgQo+MoGWcY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I4ngO/d+xRiLiKwfNaYNjhC08bl2FLNGhgC/HR9CNbRP9DtytVWlc9vOUrGEteL8/ Zd9NLIkFUDF99wFpsj9UbQp8l9Dj5RJhxYiDpwfGob21sYyqHLbGU2yzkrkDMwKvsd 2nG0dCx+J+fUMhZuaHpTDeTKOlRKc1vCszXgMvbk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tetsuo Handa , syzbot+0af00f6a2cba2058b5db@syzkaller.appspotmail.com, Joseph Qi , Mark Fasheh , Joel Becker , Junxiao Bi , Changwei Ge , Jun Piao , Andrew Morton , Sasha Levin Subject: [PATCH 5.4 250/321] ocfs2: free inode when ocfs2_get_init_inode() fails Date: Thu, 12 Dec 2024 16:02:48 +0100 Message-ID: <20241212144239.848145452@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144229.291682835@linuxfoundation.org> References: <20241212144229.291682835@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tetsuo Handa [ Upstream commit 965b5dd1894f4525f38c1b5f99b0106a07dbb5db ] syzbot is reporting busy inodes after unmount, for commit 9c89fe0af826 ("ocfs2: Handle error from dquot_initialize()") forgot to call iput() when new_inode() succeeded and dquot_initialize() failed. Link: https://lkml.kernel.org/r/e68c0224-b7c6-4784-b4fa-a9fc8c675525@I-love.SAKURA.ne.jp Fixes: 9c89fe0af826 ("ocfs2: Handle error from dquot_initialize()") Signed-off-by: Tetsuo Handa Reported-by: syzbot+0af00f6a2cba2058b5db@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=0af00f6a2cba2058b5db Tested-by: syzbot+0af00f6a2cba2058b5db@syzkaller.appspotmail.com Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Jun Piao Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/ocfs2/namei.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 34b84eb299e8e..5e87608cb987d 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -201,8 +201,10 @@ static struct inode *ocfs2_get_init_inode(struct inode *dir, umode_t mode) mode = mode_strip_sgid(dir, mode); inode_init_owner(inode, dir, mode); status = dquot_initialize(inode); - if (status) + if (status) { + iput(inode); return ERR_PTR(status); + } return inode; } -- 2.43.0