From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4273B2080D9; Thu, 12 Dec 2024 17:51:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025863; cv=none; b=d98WewbChS1oipqLaZBoEvDEdFY5KXZodW16Zc7tBZvdOENgJIVZV6qiCiMZsy2mnqfmssNNDkY1jxbnL4Q3KJo4ztIyLK1yMrsSvROEk5b9IQvdOXzIMHaz9sGIDgEmk+GWQa2Uv7dHvjeLp0tCxh+PDSlH0GmhM/x3t0Gnxvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025863; c=relaxed/simple; bh=ff0GypvfYURFDDZH57v8VLFghGzFJF4RP4JpYZkGCvI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XGVbcM1LyGKdFuHVhG9UXrbMecCfCJVZvQ1JDLVHipKkpthmt4TfgWUGdLnDtcAESJT3uwkd8LvKA6zE4+HqH5A3I/QwCeTqv8th/o0uJwcwuML7pynCQv5mrHm/e9b0RjXQBL8JwIDPqX99oxG4ko3xcOqCsi0sIXJHrBozcXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=znQ5eWXc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="znQ5eWXc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F721C4CECE; Thu, 12 Dec 2024 17:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734025862; bh=ff0GypvfYURFDDZH57v8VLFghGzFJF4RP4JpYZkGCvI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=znQ5eWXcbFLYVbS7Cvb5aoEtfPqcDU327HKqrKusXVnNtY+VcZQy9IV3t2Gv6Caci xHmeyjD0Hbiz2dXPCv2RtRZJb/dLC3X+QLpEAGMrObCzf5bF2Ae91nvcZ6gbxl2KGU IC0EZjVsmyoH/ghcpZGRMBlOIkNS439nGhRGfB8o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Geert Uytterhoeven , Simon Horman , Daniel Machon , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 272/321] net: ethernet: fs_enet: Use %pa to format resource_size_t Date: Thu, 12 Dec 2024 16:03:10 +0100 Message-ID: <20241212144240.723527666@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144229.291682835@linuxfoundation.org> References: <20241212144229.291682835@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Simon Horman [ Upstream commit 45fe45fada261e1e83fce2a07fa22835aec1cf0a ] The correct format string for resource_size_t is %pa which acts on the address of the variable to be formatted [1]. [1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229 Introduced by commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string") Flagged by gcc-14 as: drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: In function 'fs_mii_bitbang_init': drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c:126:46: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=] 126 | snprintf(bus->id, MII_BUS_ID_SIZE, "%x", res.start); | ~^ ~~~~~~~~~ | | | | | resource_size_t {aka long long unsigned int} | unsigned int | %llx No functional change intended. Compile tested only. Reported-by: Geert Uytterhoeven Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cce99@linux-m68k.org/ Signed-off-by: Simon Horman Reviewed-by: Daniel Machon Link: https://patch.msgid.link/20241014-net-pa-fmt-v1-2-dcc9afb8858b@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c index 21de56345503f..f743112730194 100644 --- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c +++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c @@ -126,7 +126,7 @@ static int fs_mii_bitbang_init(struct mii_bus *bus, struct device_node *np) * we get is an int, and the odds of multiple bitbang mdio buses * is low enough that it's not worth going too crazy. */ - snprintf(bus->id, MII_BUS_ID_SIZE, "%x", res.start); + snprintf(bus->id, MII_BUS_ID_SIZE, "%pa", &res.start); data = of_get_property(np, "fsl,mdio-pin", &len); if (!data || len != 4) -- 2.43.0