From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793BB2210DE; Thu, 12 Dec 2024 17:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025842; cv=none; b=Yqtp5jItWk8E4HG8n6BHxgCyMX4310HfPWBgGv4ubF3f9IU17it3f4izuEepcZPKiG6h1wmR6sX9qtlYr+l+HUWge2oGn+7/V/v1HeSjayfn8Mi8i5tIzoduBADME3beXLf6BEFXOma3hVMIiY1iHefqUN9D5MJvg/8kEXn+rx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734025842; c=relaxed/simple; bh=oQHwkQnxKfVMZ44973nrEf8Koq9/YLHqU5VVwgW0RpU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DagFJn8+Y8nEFyxIBQx/SdOTwYbb78XI0FsFAXyphnvB+C/TJvUroradtnEGLA/ZDL6zcCczSa7jv11M+aLXGuZpP8CBJmVc9r08aZi8APJacrXj28Psq7MrWgGEvnBVtTP+0Bg7N3qjaitP75qskgBBrdVZjW51M4lqA/smsOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=H5nLJ17O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="H5nLJ17O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00E2CC4CECE; Thu, 12 Dec 2024 17:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734025842; bh=oQHwkQnxKfVMZ44973nrEf8Koq9/YLHqU5VVwgW0RpU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H5nLJ17OZaYAY68TJKpreficM9UIi9V9A6uzmch+GaD7Gexar7JGw4QM3aBEhuQGY GVIz6M3JI8+/j1KdoDz2YgITEHLQjVzzlxMBeVLzPIpnRB5DzE1y8gl2OKbOz1t+ze 8qcfXDHUelkXNloh7niDq6ZCy3fl1VQRexL3xsFs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peter Chen , Xu Yang , Sasha Levin Subject: [PATCH 5.4 304/321] usb: chipidea: udc: handle USB Error Interrupt if IOC not set Date: Thu, 12 Dec 2024 16:03:42 +0100 Message-ID: <20241212144241.990851578@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144229.291682835@linuxfoundation.org> References: <20241212144229.291682835@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xu Yang [ Upstream commit 548f48b66c0c5d4b9795a55f304b7298cde2a025 ] As per USBSTS register description about UEI: When completion of a USB transaction results in an error condition, this bit is set by the Host/Device Controller. This bit is set along with the USBINT bit, if the TD on which the error interrupt occurred also had its interrupt on complete (IOC) bit set. UI is set only when IOC set. Add checking UEI to fix miss call isr_tr_complete_handler() when IOC have not set and transfer error happen. Acked-by: Peter Chen Signed-off-by: Xu Yang Link: https://lore.kernel.org/r/20240926022906.473319-1-xu.yang_2@nxp.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 72d62abb6f285..a6ce6b89b271a 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -1902,7 +1902,7 @@ static irqreturn_t udc_irq(struct ci_hdrc *ci) } } - if (USBi_UI & intr) + if ((USBi_UI | USBi_UEI) & intr) isr_tr_complete_handler(ci); if ((USBi_SLI & intr) && !(ci->suspended)) { -- 2.43.0