From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B01E215762; Thu, 12 Dec 2024 17:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734023601; cv=none; b=FTn1nR9uNbNzDW80+BgtOcr9AB6P1pP0uX1kSq1fLK10DvSGDBqvvA8qqec9uaMbxC2KJvTaJ/qRURgSrx4lcnPqViifAhtRnzmD56rW9IstUO1kHk+S4A24ZdoHbYnfiNBXcB9FSZm8fC+prhFvFsezbyEaSKRRrFYUTRxmEvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734023601; c=relaxed/simple; bh=OhlX+Ve/JpmX9jERcFKkILSdftjqahxh+Q/4zNV3nWo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uLr7OvaleoCVHx++2Prq7ztZzcZd4nHluL9814YjnbGnwii+Bs5HAHl+7RvSylxsd7nrSezVMhYkmViOmIsfVmPRrc1mLbMs44uSrKyOqb5/c9LcdDuYzrFq5a+aMFLK8xbQSONkbJ6Q7rRXhI/LDXtKedZDf2qMUQ1v2+ygvWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Qu27zejT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Qu27zejT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5C07C4CED4; Thu, 12 Dec 2024 17:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734023601; bh=OhlX+Ve/JpmX9jERcFKkILSdftjqahxh+Q/4zNV3nWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qu27zejTUGJUZHlvx+sfaxALkFK3NraGSUxctFuTJ8+pidzlvPt4jWB46hLlxotI8 NM7BtOZIF+kv1GR0RGE4AoXMCB50yQucj5ATZGIKByYilOl4O7748XszY8j+8wrqEG YDNr0sJc0rK+fahPtnmCTNcOQzJ+mOBvVtwWk868= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jinjie Ruan , Bryan ODonoghue , Stanimir Varbanov , Sakari Ailus , Hans Verkuil Subject: [PATCH 5.10 004/459] media: venus: Fix pm_runtime_set_suspended() with runtime pm enabled Date: Thu, 12 Dec 2024 15:55:42 +0100 Message-ID: <20241212144253.700405865@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan commit 2a20869f7d798aa2b69e45b863eaf1b1ecf98278 upstream. It is not valid to call pm_runtime_set_suspended() for devices with runtime PM enabled because it returns -EAGAIN if it is enabled already and working. So, call pm_runtime_disable() before to fix it. Cc: stable@vger.kernel.org Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper functions") Signed-off-by: Jinjie Ruan Reviewed-by: Bryan O'Donoghue Acked-by: Stanimir Varbanov Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/qcom/venus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -348,8 +348,8 @@ err_of_depopulate: of_platform_depopulate(dev); err_runtime_disable: pm_runtime_put_noidle(dev); - pm_runtime_set_suspended(dev); pm_runtime_disable(dev); + pm_runtime_set_suspended(dev); hfi_destroy(core); err_core_deinit: hfi_core_deinit(core, false);