From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 561E420967D; Thu, 12 Dec 2024 17:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734023719; cv=none; b=ZvvzWMG03T7+qOOuRqJfM3wnLAIkzYtG3EvK+S9jzdOxLSOTny0lRI4eJiWhLcRzIl/r+NiShi2J8sQORT+Z90NbH5WJ2Gk/G9nAJXPYNdHOTfajH+dROLjw1BiCxoPcYI0wwlgQtXMRZwsvI/qETKF/s8HzqloRqScuToyEh+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734023719; c=relaxed/simple; bh=1OUYFxImqGcp+VmgMbJh43DObtmp6E8b8/X7CrXkl6Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KrPLkri1iGbcd0fzW5TwII1l7qW8Wq1WNIC5h+fid1DJgDAW6qy7BtTJ7ueGqnr2pwKo/l3dRacvZE6c6oYRPAPb2sUwwcKkf8WN4or7jUgoHX5wK5ar3tu6/GR4xWqdIC5E9LvanlXXIAD3zi2d1xMeSFYni8G4Qfxo2Pg0V20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eNFVg5zx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eNFVg5zx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3755C4CECE; Thu, 12 Dec 2024 17:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734023719; bh=1OUYFxImqGcp+VmgMbJh43DObtmp6E8b8/X7CrXkl6Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eNFVg5zxAupGVS8AqKgOxF508ihB65B6ztZ8DOKBIXY6fjXslPxipEsZCT99pVF1D DLNcYQYXFfEZBBfAnGHpgj/HPkDflCbw8BKHlYMD1ir709vRFuQ63iBQlBuYlRtHnY 0TV6QaOCSNOWoKOwIkufRHGpbFxbJMJxR1F/oZjc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ryusuke Konishi , Ubisectech Sirius , syzbot+9982fb8d18eba905abe2@syzkaller.appspotmail.com, Tejun Heo , Andrew Morton Subject: [PATCH 5.10 019/459] nilfs2: fix null-ptr-deref in block_touch_buffer tracepoint Date: Thu, 12 Dec 2024 15:55:57 +0100 Message-ID: <20241212144254.286696123@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ryusuke Konishi commit cd45e963e44b0f10d90b9e6c0e8b4f47f3c92471 upstream. Patch series "nilfs2: fix null-ptr-deref bugs on block tracepoints". This series fixes null pointer dereference bugs that occur when using nilfs2 and two block-related tracepoints. This patch (of 2): It has been reported that when using "block:block_touch_buffer" tracepoint, touch_buffer() called from __nilfs_get_folio_block() causes a NULL pointer dereference, or a general protection fault when KASAN is enabled. This happens because since the tracepoint was added in touch_buffer(), it references the dev_t member bh->b_bdev->bd_dev regardless of whether the buffer head has a pointer to a block_device structure. In the current implementation, the block_device structure is set after the function returns to the caller. Here, touch_buffer() is used to mark the folio/page that owns the buffer head as accessed, but the common search helper for folio/page used by the caller function was optimized to mark the folio/page as accessed when it was reimplemented a long time ago, eliminating the need to call touch_buffer() here in the first place. So this solves the issue by eliminating the touch_buffer() call itself. Link: https://lkml.kernel.org/r/20241106160811.3316-1-konishi.ryusuke@gmail.com Link: https://lkml.kernel.org/r/20241106160811.3316-2-konishi.ryusuke@gmail.com Fixes: 5305cb830834 ("block: add block_{touch|dirty}_buffer tracepoint") Signed-off-by: Ryusuke Konishi Reported-by: Ubisectech Sirius Closes: https://lkml.kernel.org/r/86bd3013-887e-4e38-960f-ca45c657f032.bugreport@valiantsec.com Reported-by: syzbot+9982fb8d18eba905abe2@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=9982fb8d18eba905abe2 Tested-by: syzbot+9982fb8d18eba905abe2@syzkaller.appspotmail.com Cc: Tejun Heo Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- fs/nilfs2/page.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/nilfs2/page.c +++ b/fs/nilfs2/page.c @@ -39,7 +39,6 @@ __nilfs_get_page_block(struct page *page first_block = (unsigned long)index << (PAGE_SHIFT - blkbits); bh = nilfs_page_get_nth_block(page, block - first_block); - touch_buffer(bh); wait_on_buffer(bh); return bh; }