From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DDBF13CA93; Thu, 12 Dec 2024 17:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024112; cv=none; b=LdP4dSFxtcVlt1P/2nQwuKRCpC9yV7CVTbyHRIQeA9sWf+KwHvUxuZYBfKlaPeTo8SU6JHvmLcBC62EzzYAxIIU74jMfwMwQFyRQ02mF3R7D/AZVZ8v7F6t7fmoc1GIpmmn41AMfRiKa2EVm5UMI4wKpSpu2r2lueKnhM7nJ2NA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024112; c=relaxed/simple; bh=NHIyJu1q98W5akM7sOyw+oSrg23oVhpA7SZ/9NS/Ds8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aU4OCkual+LE+7x2wo8PEMdjRLkmdOSTntjzow8zNO+KDabGJE0iz4r1GUNeNgH9QbkAohw+i5REvle0eqZVvexpDfVadOxa97WyPzj7k11kwaEj2r6CGxUGnKs1Y01HVKstoWW1Hv7V8Xqz0ZvwN278OF/cfkIqLBuyCZ7P9n8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cR1vXEhn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cR1vXEhn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91FD1C4CECE; Thu, 12 Dec 2024 17:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024112; bh=NHIyJu1q98W5akM7sOyw+oSrg23oVhpA7SZ/9NS/Ds8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cR1vXEhnzsusAe+ZiOe61DYWtYX7iIqpZV5OfDo7558csgezb39qXCSBzAs7PJHND 6PB+pySmw4iFLeHbwVJy4ZGj16+IWNPX7J8GVB3uM6jWc9p7lotX8KzJaEiW+7WdB1 Km3CxACX+jFPq4YXMXzXn8DqYBRFv1PN96L0hasQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Can , Felix Kuehling , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 150/459] drm/amdkfd: Fix wrong usage of INIT_WORK() Date: Thu, 12 Dec 2024 15:58:08 +0100 Message-ID: <20241212144259.437356622@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuan Can [ Upstream commit 21cae8debc6a1d243f64fa82cd1b41cb612b5c61 ] In kfd_procfs_show(), the sdma_activity_work_handler is a local variable and the sdma_activity_work_handler.sdma_activity_work should initialize with INIT_WORK_ONSTACK() instead of INIT_WORK(). Fixes: 32cb59f31362 ("drm/amdkfd: Track SDMA utilization per process") Signed-off-by: Yuan Can Signed-off-by: Felix Kuehling Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c index 534f2dec6356f..184527afe2bd5 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -312,8 +312,8 @@ static ssize_t kfd_procfs_show(struct kobject *kobj, struct attribute *attr, attr_sdma); struct kfd_sdma_activity_handler_workarea sdma_activity_work_handler; - INIT_WORK(&sdma_activity_work_handler.sdma_activity_work, - kfd_sdma_activity_worker); + INIT_WORK_ONSTACK(&sdma_activity_work_handler.sdma_activity_work, + kfd_sdma_activity_worker); sdma_activity_work_handler.pdd = pdd; sdma_activity_work_handler.sdma_activity_counter = 0; @@ -321,6 +321,7 @@ static ssize_t kfd_procfs_show(struct kobject *kobj, struct attribute *attr, schedule_work(&sdma_activity_work_handler.sdma_activity_work); flush_work(&sdma_activity_work_handler.sdma_activity_work); + destroy_work_on_stack(&sdma_activity_work_handler.sdma_activity_work); return snprintf(buffer, PAGE_SIZE, "%llu\n", (sdma_activity_work_handler.sdma_activity_counter)/ -- 2.43.0