From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A488313CA93; Thu, 12 Dec 2024 17:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024228; cv=none; b=R2sG4pWtXDWuK/1vS+yT5lS6FCdSUhhjkFst5fDV1O4+tvZq3F41MghviWjA8xq9W1H0qaAopoeDbHhesiKc1iB70bm2pL0WyHmIRXHBWnA1XYVPy2jiu4nCo2Z4W5IFL4PsrNfz9nZAkqYI9ZNMPjblvAwokA8moMb3n8Xm+Xk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024228; c=relaxed/simple; bh=zMXAbRT6K0pJaQXO3GjJQYdDKupVVymYfZisWbhW4v4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rNPcG4bQmZs+/Ov5lXYjzvkr5XEkQ4PeH2c60vym1l4gY8xekDo7N9VY5XukNy2pK8LwU7W7YEa6t1R9fVqM1abLd0bmj7O67l/EQ95LkP5g0Tb1df6EJpq3c58NfHQbxGKZBF82CWiG20my7J8g7LTLhP0qhBV2w/KpccL2Wdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tTZ7H0GH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tTZ7H0GH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22DD0C4CED0; Thu, 12 Dec 2024 17:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024228; bh=zMXAbRT6K0pJaQXO3GjJQYdDKupVVymYfZisWbhW4v4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tTZ7H0GHzGKAKUQDhmwItIhivq2bY5iRnxyqzxu0I7+ekH4saFZhbPSyYNDK2ALS7 JiAT9inU/yrxOrY45u43CTogCo0jsKvH3JBrlq3hs/8byCvn9PNEsKEWfZ0VVL7wgr hJLcOICIuToPbwHikzJ6gcsMZHodBnKAldX0nALY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Somnath Kotur , Pavan Chebbi , Kashyap Desai , Saravanan Vajravel , Michael Chan , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 228/459] bnxt_en: Reserve rings after PCIe AER recovery if NIC interface is down Date: Thu, 12 Dec 2024 15:59:26 +0100 Message-ID: <20241212144302.575958204@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Saravanan Vajravel [ Upstream commit 5311598f7f3293683cdc761df71ae3469327332c ] After successful PCIe AER recovery, FW will reset all resource reservations. If it is IF_UP, the driver will call bnxt_open() and all resources will be reserved again. It it is IF_DOWN, we should call bnxt_reserve_rings() so that we can reserve resources including RoCE resources to allow RoCE to resume after AER. Without this patch, RoCE fails to resume in this IF_DOWN scenario. Later, if it becomes IF_UP, bnxt_open() will see that resources have been reserved and will not reserve again. Fixes: fb1e6e562b37 ("bnxt_en: Fix AER recovery.") Reviewed-by: Somnath Kotur Reviewed-by: Pavan Chebbi Reviewed-by: Kashyap Desai Signed-off-by: Saravanan Vajravel Signed-off-by: Michael Chan Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 059552f4154d1..40c53404bccbb 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -13107,8 +13107,12 @@ static void bnxt_io_resume(struct pci_dev *pdev) rtnl_lock(); err = bnxt_hwrm_func_qcaps(bp); - if (!err && netif_running(netdev)) - err = bnxt_open(netdev); + if (!err) { + if (netif_running(netdev)) + err = bnxt_open(netdev); + else + err = bnxt_reserve_rings(bp, true); + } bnxt_ulp_start(bp, err); if (!err) { -- 2.43.0