From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 875D92144C4; Thu, 12 Dec 2024 17:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024278; cv=none; b=A4jEQnho+hXT5NZBPF0y/gViV9ejNbrP4vh7y2L6KksW1Y3DpgONdeFyg7nBVHnStIbnyc/mZxHM/CXIVMbSVfv34FPdOnlyBwcrcb3R7Vs0h4YRmB1zBRmempbkkU0KJsJSBuoLVEA2a0IkUlAQXbvKH3k8jq/C4n3XxUK0CAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024278; c=relaxed/simple; bh=aRtFp0HXrqFEapL6wK3/y9LJoN75hz0TjuqsDpeSnzI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eDbbETsoQr1mHdXah1RJu0seUDVBDCQjvj4I68DuFvictpi6Qvc7m6mn1WmcaDx7VqB3VgiAXUPZtj2tgbD92SyZTrwIzdsbrNCPPe5VnotdjLQf19WhA4GUuia1PfexiaPwAC9dvRltJv9CCOojw3jXIKPmg4oQ1i4ESfVrOGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=18VU+3Fa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="18VU+3Fa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05ADEC4CECE; Thu, 12 Dec 2024 17:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024278; bh=aRtFp0HXrqFEapL6wK3/y9LJoN75hz0TjuqsDpeSnzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=18VU+3FaXUvywYpsSC8O8VO23VtgBsTGHJ3Fm96nnv835bTrUw0nWh1ZAEVNo3Bcu HV/+XkQHJLkXbaDjbGULcJPi6YRFfgAfKjuVObMIvFYnMKSUV+EYUt8vvQ6eSotwmY V+436vqtsYDzAVhnn5DMvDPTGpFJiT0a6LzXaDEc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Manikanta Mylavarapu , Konrad Dybcio , Bjorn Andersson Subject: [PATCH 5.10 243/459] soc: qcom: socinfo: fix revision check in qcom_socinfo_probe() Date: Thu, 12 Dec 2024 15:59:41 +0100 Message-ID: <20241212144303.182654369@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Manikanta Mylavarapu commit 128fdbf36cddc2a901c4889ba1c89fa9f2643f2c upstream. In success case, the revision holds a non-null pointer. The current logic incorrectly returns an error for a non-null pointer, whereas it should return an error for a null pointer. The socinfo driver for IPQ9574 and IPQ5332 is currently broken, resulting in the following error message qcom-socinfo qcom-socinfo: probe with driver qcom-socinfo failed with error -12 Add a null check for the revision to ensure it returns an error only in failure case (null pointer). Fixes: e694d2b5c58b ("soc: qcom: Add check devm_kasprintf() returned value") Signed-off-by: Manikanta Mylavarapu Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20241016144852.2888679-1-quic_mmanikan@quicinc.com Signed-off-by: Bjorn Andersson Signed-off-by: Greg Kroah-Hartman --- drivers/soc/qcom/socinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/soc/qcom/socinfo.c +++ b/drivers/soc/qcom/socinfo.c @@ -507,7 +507,7 @@ static int qcom_socinfo_probe(struct pla qs->attr.revision = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%u.%u", SOCINFO_MAJOR(le32_to_cpu(info->ver)), SOCINFO_MINOR(le32_to_cpu(info->ver))); - if (!qs->attr.soc_id || qs->attr.revision) + if (!qs->attr.soc_id || !qs->attr.revision) return -ENOMEM; if (offsetof(struct socinfo, serial_num) <= item_size) {