From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2734013CA93; Thu, 12 Dec 2024 17:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024421; cv=none; b=Jjo8lkfpDlqQ/rhV4Kq5SIjneEQnUVpjH8tXaOC49eihiLY2BtPsx6T0UwJ6zILfyw7SYa6oXeNXAioJQAq/z/NlPJdPQBETd7Ude3QHRxc4uNbkn/1ceUhhnzpUgIkrQcK0IkNFH7hVTYwCfiEjrU6yNCDl4Pmi6GxnLQWIS7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024421; c=relaxed/simple; bh=P0igu6TrXkrxM8rYTy4qyNC1uozzVhWFci6wT5mRJnA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hTIO2IJ/sG87/ra8w37v+ChxMsRzsrxRCya1G+v38tgSrybRBfGPGoV00tzLWTjQSqansbeWx0RAMZ11ula7lO6dtRBInsp7NoHfk/MqTWbs2zeBTCZyFSyxJyoiBWG5+qJBwKycVHBH8iNo6C9ngEZjcvFw5iuu4SNeBts7PVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KxO9cDOQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KxO9cDOQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1290C4CED0; Thu, 12 Dec 2024 17:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024421; bh=P0igu6TrXkrxM8rYTy4qyNC1uozzVhWFci6wT5mRJnA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KxO9cDOQ2Q68POLjXw5/HBJmDFBsErpxqLL4kIb2jqUW0Pv3hIXz6PtxNzSzHw20V x1X6p2oriUGtM+qOHGLjwbK8h5eXqFGDDImgTNZKV9Vrd5f3WQnj71UlmDMZf89RAW lVQZLEoHD7zcqRUI4Zp3bFeOSSgBum4b7o7macgg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Erkun , Trond Myklebust , Sasha Levin Subject: [PATCH 5.10 291/459] NFSv4.0: Fix a use-after-free problem in the asynchronous open() Date: Thu, 12 Dec 2024 16:00:29 +0100 Message-ID: <20241212144305.126692848@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Trond Myklebust [ Upstream commit 2fdb05dc0931250574f0cb0ebeb5ed8e20f4a889 ] Yang Erkun reports that when two threads are opening files at the same time, and are forced to abort before a reply is seen, then the call to nfs_release_seqid() in nfs4_opendata_free() can result in a use-after-free of the pointer to the defunct rpc task of the other thread. The fix is to ensure that if the RPC call is aborted before the call to nfs_wait_on_sequence() is complete, then we must call nfs_release_seqid() in nfs4_open_release() before the rpc_task is freed. Reported-by: Yang Erkun Fixes: 24ac23ab88df ("NFSv4: Convert open() into an asynchronous RPC call") Reviewed-by: Yang Erkun Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- fs/nfs/nfs4proc.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 1ff3f9efbe519..ac3fab214df12 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2518,12 +2518,14 @@ static void nfs4_open_release(void *calldata) struct nfs4_opendata *data = calldata; struct nfs4_state *state = NULL; + /* In case of error, no cleanup! */ + if (data->rpc_status != 0 || !data->rpc_done) { + nfs_release_seqid(data->o_arg.seqid); + goto out_free; + } /* If this request hasn't been cancelled, do nothing */ if (!data->cancelled) goto out_free; - /* In case of error, no cleanup! */ - if (data->rpc_status != 0 || !data->rpc_done) - goto out_free; /* In case we need an open_confirm, no cleanup! */ if (data->o_res.rflags & NFS4_OPEN_RESULT_CONFIRM) goto out_free; -- 2.43.0