From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D2A4221DA4; Thu, 12 Dec 2024 17:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024605; cv=none; b=vGo5X5Y6BcKhN5oUSdo9VYft3GtygFl+1pwEi08dB68kviWMOA41vmQ6W9PQbnnqKWrUwgqipb4SxX9IlSwvl29oXIStCdbTRw5KH77UnRbUCGj+pvdiVLomjgKVMBSdHQny3Fp0cMqPkSF6kaEr3XOsQHOX16MNZ67IYXJtcfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024605; c=relaxed/simple; bh=QkhtXDXfhF3M6QIl5Kp3zT5r3P3ZhHgZBq05v42Fsyw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cIx7ojvCfQIwIoh/xATd3dSNg1kr+MhBpaTfSxYNaHjqJxS/kx/IA+rVxkXlXHSqe35MYC17NFmmcvvj7U1g3vzcG6A5N7Om2cGQ5FjySTg7UAvknxN91h3QaHI/GQJ/wygrfzQaM+cBB3rgmtmJQDfPPEhkub6FfmMBpAxqkPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Zh5Y4H58; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Zh5Y4H58" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B64D1C4CECE; Thu, 12 Dec 2024 17:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024605; bh=QkhtXDXfhF3M6QIl5Kp3zT5r3P3ZhHgZBq05v42Fsyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zh5Y4H58/DiNELiWBcXEuguqCJL7J5icsC1VGT4O4mGAOQJtBNGbIJj8BzwtBG5cD 7Fa7F/Q/eTZqLm5sSxU/3NO2r5bAFE3Nohq1baDahWwXiNkTD2wXCXLd5uVFnmkmMb K6hkAeM5qpBNHH3LAORIByn3NDwYGWLJetUE8gb4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Erkun , Jeff Layton , Chuck Lever Subject: [PATCH 5.10 321/459] nfsd: make sure exp active before svc_export_show Date: Thu, 12 Dec 2024 16:00:59 +0100 Message-ID: <20241212144306.336651501@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yang Erkun commit be8f982c369c965faffa198b46060f8853e0f1f0 upstream. The function `e_show` was called with protection from RCU. This only ensures that `exp` will not be freed. Therefore, the reference count for `exp` can drop to zero, which will trigger a refcount use-after-free warning when `exp_get` is called. To resolve this issue, use `cache_get_rcu` to ensure that `exp` remains active. ------------[ cut here ]------------ refcount_t: addition on 0; use-after-free. WARNING: CPU: 3 PID: 819 at lib/refcount.c:25 refcount_warn_saturate+0xb1/0x120 CPU: 3 UID: 0 PID: 819 Comm: cat Not tainted 6.12.0-rc3+ #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.1-2.fc37 04/01/2014 RIP: 0010:refcount_warn_saturate+0xb1/0x120 ... Call Trace: e_show+0x20b/0x230 [nfsd] seq_read_iter+0x589/0x770 seq_read+0x1e5/0x270 vfs_read+0x125/0x530 ksys_read+0xc1/0x160 do_syscall_64+0x5f/0x170 entry_SYSCALL_64_after_hwframe+0x76/0x7e Fixes: bf18f163e89c ("NFSD: Using exp_get for export getting") Cc: stable@vger.kernel.org # 4.20+ Signed-off-by: Yang Erkun Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/export.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c @@ -1318,9 +1318,12 @@ static int e_show(struct seq_file *m, vo return 0; } - exp_get(exp); + if (!cache_get_rcu(&exp->h)) + return 0; + if (cache_check(cd, &exp->h, NULL)) return 0; + exp_put(exp); return svc_export_show(m, cd, cp); }