From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE714213E6F; Thu, 12 Dec 2024 17:31:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024691; cv=none; b=X21G07P0x4e06keL7iL028I3j5MzDPBqcNhFdxfgf/Bk5HGESV2RgyTyBrlQdtXJBNZAZEMAgyEjzOtB8AIKY0izs1EcvqKTTZs6AqFJELr/7yIx8lukm42zb8HHA7isvxBAafztHWYUHIgpPVDk5fk+VmpBD8RM5m1cKnKUNHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024691; c=relaxed/simple; bh=3g0KFebKfY6Wm9FZ+6cZzJyEaZUcfEXi7R2avYtmvi8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IPA/BzBLQXh0IdxxLmwWVTZW6v6paN+Uc8OyDZJpa4uvZYKejA7lws/DN7HqZDaU4GDgprVjpogmwmmpLjXWCaG9eFa+8QY5VEiMe3VMnFsnCthVzXh+j3KJjdBShhyG5i57Gmaqsr4/yFZGCH7EMwIu9B6kP5RzSi/YehYpoZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qjnuJUm4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qjnuJUm4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7538FC4CED0; Thu, 12 Dec 2024 17:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024690; bh=3g0KFebKfY6Wm9FZ+6cZzJyEaZUcfEXi7R2avYtmvi8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qjnuJUm4cPWugVBhoAJviCkkKYkhaK1z63YSfgbTrvterdoQMoS6UeTAvc8azLhfg 9xk2M4hObr8mjSubmbIHJNY7qP8AcQKrGgI+uSeKKk6eCbZllT8qnZQcEZ5mA+t9Go muQfmS1gwbtTK6hJHmidzaV4m6RclS2z8lpsjU58= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Miquel Raynal , Frank Li , Alexandre Belloni , Sasha Levin Subject: [PATCH 5.10 350/459] i3c: master: Replace hard code 2 with macro I3C_ADDR_SLOT_STATUS_BITS Date: Thu, 12 Dec 2024 16:01:28 +0100 Message-ID: <20241212144307.485040609@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Frank Li [ Upstream commit 16aed0a6520ba01b7d22c32e193fc1ec674f92d4 ] Replace the hardcoded value 2, which indicates 2 bits for I3C address status, with the predefined macro I3C_ADDR_SLOT_STATUS_BITS. Improve maintainability and extensibility of the code. Reviewed-by: Miquel Raynal Signed-off-by: Frank Li Link: https://lore.kernel.org/r/20241021-i3c_dts_assign-v8-1-4098b8bde01e@nxp.com Signed-off-by: Alexandre Belloni Stable-dep-of: 851bd21cdb55 ("i3c: master: Fix dynamic address leak when 'assigned-address' is present") Signed-off-by: Sasha Levin --- drivers/i3c/master.c | 4 ++-- include/linux/i3c/master.h | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 63c79b3cd7d4f..49a744577f4ea 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -348,7 +348,7 @@ static enum i3c_addr_slot_status i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) { unsigned long status; - int bitpos = addr * 2; + int bitpos = addr * I3C_ADDR_SLOT_STATUS_BITS; if (addr > I2C_MAX_ADDR) return I3C_ADDR_SLOT_RSVD; @@ -362,7 +362,7 @@ i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) static void i3c_bus_set_addr_slot_status(struct i3c_bus *bus, u16 addr, enum i3c_addr_slot_status status) { - int bitpos = addr * 2; + int bitpos = addr * I3C_ADDR_SLOT_STATUS_BITS; unsigned long *ptr; if (addr > I2C_MAX_ADDR) diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index 9cb39d901cd5f..06cba906e4e41 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -291,6 +291,8 @@ enum i3c_addr_slot_status { I3C_ADDR_SLOT_STATUS_MASK = 3, }; +#define I3C_ADDR_SLOT_STATUS_BITS 2 + /** * struct i3c_bus - I3C bus object * @cur_master: I3C master currently driving the bus. Since I3C is multi-master @@ -332,7 +334,7 @@ enum i3c_addr_slot_status { struct i3c_bus { struct i3c_dev_desc *cur_master; int id; - unsigned long addrslots[((I2C_MAX_ADDR + 1) * 2) / BITS_PER_LONG]; + unsigned long addrslots[((I2C_MAX_ADDR + 1) * I3C_ADDR_SLOT_STATUS_BITS) / BITS_PER_LONG]; enum i3c_bus_mode mode; struct { unsigned long i3c; -- 2.43.0