From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C46052236EB; Thu, 12 Dec 2024 17:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024831; cv=none; b=rYr+OWK/syTA7YE/jruLE+I4yadKkgeYTLBiaj+mkpbKiXhG7OODByXwZCzKbb+ICbeQAW3cW2I/x3AF1YzADUS5JEFg32VzhA5uRGuLDYwLODJxVbQkkncQANBU0mLIfZXS0bfsdZHuQeBzKT5dJF8X32/Lp0+4FcnAdSsoA8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024831; c=relaxed/simple; bh=LzONuZuY/HMtvW+IdGleFParhwIHzqZIY2YUCsFpdEM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qVcZJ/wL5vYkAxT0pdokdRVxXCVWyqYvu3N11sLtpFe4dicTppAxDAzoYsVGaOogurIL+PRECw7uZfMOGjk8Pvkv3pNtR5EmCRR0upTxu/7K9W6kuQsR17hE+4XrNtRDDXApbcdgrW1nHV38quj8WnV63tyC/2Eqh9h6vGwBwow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eLky57F7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eLky57F7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A320C4CECE; Thu, 12 Dec 2024 17:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024831; bh=LzONuZuY/HMtvW+IdGleFParhwIHzqZIY2YUCsFpdEM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eLky57F7MRzlhXuutmsiXDnqeRTE50LPNidWqsv9Ymd4JYDPO87H/i9VZFW4gHhzd fhypGq8paRvdtQoNKvZ+Fs4FmHc7bx6lSk9Q8lrCP8S52ct4i5RbVpXxdp2Z93OSGA Vs7b/7ZAoM/bgn/Uelw/IPS0bi6VAwHa1uQeSiPQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mengyuan Lou , Bjorn Helgaas , Sasha Levin Subject: [PATCH 5.10 427/459] PCI: Add ACS quirk for Wangxun FF5xxx NICs Date: Thu, 12 Dec 2024 16:02:45 +0100 Message-ID: <20241212144310.630944955@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mengyuan Lou [ Upstream commit aa46a3736afcb7b0793766d22479b8b99fc1b322 ] Wangxun FF5xxx NICs are similar to SFxxx, RP1000 and RP2000 NICs. They may be multi-function devices, but they do not advertise an ACS capability. But the hardware does isolate FF5xxx functions as though it had an ACS capability and PCI_ACS_RR and PCI_ACS_CR were set in the ACS Control register, i.e., all peer-to-peer traffic is directed upstream instead of being routed internally. Add ACS quirk for FF5xxx NICs in pci_quirk_wangxun_nic_acs() so the functions can be in independent IOMMU groups. Link: https://lore.kernel.org/r/E16053DB2B80E9A5+20241115024604.30493-1-mengyuanlou@net-swift.com Signed-off-by: Mengyuan Lou Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin --- drivers/pci/quirks.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 86b91f8da1caa..37cc08d706367 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4829,18 +4829,21 @@ static int pci_quirk_brcm_acs(struct pci_dev *dev, u16 acs_flags) } /* - * Wangxun 10G/1G NICs have no ACS capability, and on multi-function - * devices, peer-to-peer transactions are not be used between the functions. - * So add an ACS quirk for below devices to isolate functions. + * Wangxun 40G/25G/10G/1G NICs have no ACS capability, but on + * multi-function devices, the hardware isolates the functions by + * directing all peer-to-peer traffic upstream as though PCI_ACS_RR and + * PCI_ACS_CR were set. * SFxxx 1G NICs(em). * RP1000/RP2000 10G NICs(sp). + * FF5xxx 40G/25G/10G NICs(aml). */ static int pci_quirk_wangxun_nic_acs(struct pci_dev *dev, u16 acs_flags) { switch (dev->device) { - case 0x0100 ... 0x010F: - case 0x1001: - case 0x2001: + case 0x0100 ... 0x010F: /* EM */ + case 0x1001: case 0x2001: /* SP */ + case 0x5010: case 0x5025: case 0x5040: /* AML */ + case 0x5110: case 0x5125: case 0x5140: /* AML */ return pci_acs_ctrl_enabled(acs_flags, PCI_ACS_SV | PCI_ACS_RR | PCI_ACS_CR | PCI_ACS_UF); } -- 2.43.0