From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0256223C68; Thu, 12 Dec 2024 17:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024930; cv=none; b=G+/km3266E3kqX5tXBa2m/jZeXmEi4GQSaugQMLwyoYzqwx5aYDa3ln4X2Juw7WDLXPDARVSrnEY6vnO8w7P/GIICMo3oH9KRyazBUx1HUw7JHwtT+DamKNaMWw+Sc8bQRKjws0gWHUw8jpe7ZtPZiGGNT88jE80aU4n5hbSkag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024930; c=relaxed/simple; bh=QFmjWs5POCujcu0skGjcMrwqcvoKSwHs8zt5/29raZ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hckJAcq5MpJ8gCrFO7tfugE/uqBpL2WgYDNTSjq13S8yICjI3xTgIfnVU9p+t18B00ZsDjP6WXHMGKbqks4zhEEptRNb4t8TMxAbSUGj3YkvXsBCUiFAL59w7lUUrwKTAQLAwIthS9+2P081cGYIHI9Nr0c6q85mz2iI99j+iSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ACP8pA6M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ACP8pA6M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22448C4CED0; Thu, 12 Dec 2024 17:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024930; bh=QFmjWs5POCujcu0skGjcMrwqcvoKSwHs8zt5/29raZ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ACP8pA6M7MZM96Nm3y0+969k0LrZ1p6nqRNPOqrpJubJbzQFyvWKf3P4WQkFBFQlz lNTjlmdvgns/KLdFGox7fzRw0bO5ixE6PojvFzHykOzA4tM/w7H8wiqPiJN7qZJQc+ Yk0Gj1TU7Hzgfhcd/Ds2yHHRR2wsH4OyYstfZslk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shusen Li , Kunkun Jiang , Jing Zhang , Oliver Upton Subject: [PATCH 5.10 444/459] KVM: arm64: vgic-its: Clear DTE when MAPD unmaps a device Date: Thu, 12 Dec 2024 16:03:02 +0100 Message-ID: <20241212144311.309587367@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kunkun Jiang commit e9649129d33dca561305fc590a7c4ba8c3e5675a upstream. vgic_its_save_device_tables will traverse its->device_list to save DTE for each device. vgic_its_restore_device_tables will traverse each entry of device table and check if it is valid. Restore if valid. But when MAPD unmaps a device, it does not invalidate the corresponding DTE. In the scenario of continuous saves and restores, there may be a situation where a device's DTE is not saved but is restored. This is unreasonable and may cause restore to fail. This patch clears the corresponding DTE when MAPD unmaps a device. Cc: stable@vger.kernel.org Fixes: 57a9a117154c ("KVM: arm64: vgic-its: Device table save/restore") Co-developed-by: Shusen Li Signed-off-by: Shusen Li Signed-off-by: Kunkun Jiang [Jing: Update with entry write helper] Signed-off-by: Jing Zhang Link: https://lore.kernel.org/r/20241107214137.428439-5-jingzhangos@google.com Signed-off-by: Oliver Upton Signed-off-by: Greg Kroah-Hartman --- arch/arm64/kvm/vgic/vgic-its.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/arch/arm64/kvm/vgic/vgic-its.c +++ b/arch/arm64/kvm/vgic/vgic-its.c @@ -1182,9 +1182,11 @@ static int vgic_its_cmd_handle_mapd(stru bool valid = its_cmd_get_validbit(its_cmd); u8 num_eventid_bits = its_cmd_get_size(its_cmd); gpa_t itt_addr = its_cmd_get_ittaddr(its_cmd); + int dte_esz = vgic_its_get_abi(its)->dte_esz; struct its_device *device; + gpa_t gpa; - if (!vgic_its_check_id(its, its->baser_device_table, device_id, NULL)) + if (!vgic_its_check_id(its, its->baser_device_table, device_id, &gpa)) return E_ITS_MAPD_DEVICE_OOR; if (valid && num_eventid_bits > VITS_TYPER_IDBITS) @@ -1205,7 +1207,7 @@ static int vgic_its_cmd_handle_mapd(stru * is an error, so we are done in any case. */ if (!valid) - return 0; + return vgic_its_write_entry_lock(its, gpa, 0, dte_esz); device = vgic_its_alloc_device(its, device_id, itt_addr, num_eventid_bits);