From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C13DC2210DA; Thu, 12 Dec 2024 16:41:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734021698; cv=none; b=eNM3ZvRyWhM0WYkvlMbjv0IglTN3vdwoTwez40525aSiIPu/HrwNb/3+99NTHrqusugOPpYisPWQhIygcmUid4Kfm0oDjD4/zhDlYttc5f4pNIdL5rkS4yHR+Pw3jaCxf6TAwLvELXBhfcDMBWO+XUjAivHBK4TgETzWyDSET+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734021698; c=relaxed/simple; bh=eFT3BTp68aU1TdsdH3DjC/sXfHIB0cD9fkILg0W2YeM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rrplEqMrtph3ARGsQiIoZ4R8OXnLSZM2OKAf156KLlzuzZpzsJJp/I7k3nNEK82ZQSKaEKXkMmCeKTG0gGonSQWugr0SVKttHUoAU78X1ntTSRsq8UrZxfoz7QLS224nwuLjOeKz4cheR1oXD2Pa4tDS+fZjKydUUchfp703Xzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CnyV/qXN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CnyV/qXN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17506C4CECE; Thu, 12 Dec 2024 16:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734021698; bh=eFT3BTp68aU1TdsdH3DjC/sXfHIB0cD9fkILg0W2YeM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CnyV/qXNT63peeDJ1YQkJi+hc2lreO3LiJ3zUSxaQGBRhMjmmt8/q+VjGha56CdNn c7yR9HbhXCxel6zdpGPm8BNsDlZDeBncHEI9pQCmgweEliFtoCYMgXkw7AEq68OhrL yOeXYs2KWAqgn+lFPoiHmyXMkVPAXuZC2QdOtgxw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Dan Carpenter , Mauro Carvalho Chehab , Nathan Chancellor Subject: [PATCH 5.15 038/565] media: dvbdev: fix the logic when DVB_DYNAMIC_MINORS is not set Date: Thu, 12 Dec 2024 15:53:53 +0100 Message-ID: <20241212144312.967680070@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144311.432886635@linuxfoundation.org> References: <20241212144311.432886635@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mauro Carvalho Chehab commit a4aebaf6e6efff548b01a3dc49b4b9074751c15b upstream. When CONFIG_DVB_DYNAMIC_MINORS, ret is not initialized, and a semaphore is left at the wrong state, in case of errors. Make the code simpler and avoid mistakes by having just one error check logic used weather DVB_DYNAMIC_MINORS is used or not. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202410201717.ULWWdJv8-lkp@intel.com/ Signed-off-by: Mauro Carvalho Chehab Link: https://lore.kernel.org/r/9e067488d8935b8cf00959764a1fa5de85d65725.1730926254.git.mchehab+huawei@kernel.org Cc: Nathan Chancellor Signed-off-by: Greg Kroah-Hartman --- drivers/media/dvb-core/dvbdev.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) --- a/drivers/media/dvb-core/dvbdev.c +++ b/drivers/media/dvb-core/dvbdev.c @@ -544,6 +544,9 @@ int dvb_register_device(struct dvb_adapt for (minor = 0; minor < MAX_DVB_MINORS; minor++) if (dvb_minors[minor] == NULL) break; +#else + minor = nums2minor(adap->num, type, id); +#endif if (minor >= MAX_DVB_MINORS) { if (new_node) { list_del (&new_node->list_head); @@ -557,17 +560,7 @@ int dvb_register_device(struct dvb_adapt mutex_unlock(&dvbdev_register_lock); return -EINVAL; } -#else - minor = nums2minor(adap->num, type, id); - if (minor >= MAX_DVB_MINORS) { - dvb_media_device_free(dvbdev); - list_del(&dvbdev->list_head); - kfree(dvbdev); - *pdvbdev = NULL; - mutex_unlock(&dvbdev_register_lock); - return ret; - } -#endif + dvbdev->minor = minor; dvb_minors[minor] = dvb_device_get(dvbdev); up_write(&minor_rwsem);