From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37A32253EB; Thu, 12 Dec 2024 16:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734019805; cv=none; b=bb0PQUgZ9KwDTcK2eYHym0Q/2NAf6ihOWo1ylSK+4Br0m4Onzux6IFjPKQxFYA8uSDVNpbP0IsqKl15I7FlpzdM+w+AaWXD2EBxx3vK7ZheXcwTz8Pg+XtnQzvhqxdLiGbFBfV3zK1OnIdBo4RopXUFDikXguVdj0+N6AGZyGkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734019805; c=relaxed/simple; bh=gIJGrDC1RBH4tOTmVlxQXhZcRIzUylW/WcfT6M31vH8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eeEydcietSHWi79i0EdlKFW/nMVZhnorZTwmnexU7alqH+EAkqweXEUY0lr0SSktYkVII3DcI08xmLpbEBroaQi8j9Cl4AefyOE+0TJ8OEFpLmfiYW9FzFddNks9aonYkgriBkmtHmR0rIAWiYET8JOknYTkvO1Wr6Ju+ARMnSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=n9ZfooR4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="n9ZfooR4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44FBBC4CECE; Thu, 12 Dec 2024 16:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734019804; bh=gIJGrDC1RBH4tOTmVlxQXhZcRIzUylW/WcfT6M31vH8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n9ZfooR4qMQAQAUNgPBPCBq5YsBIufM/3ECypySauVseui3CQFQLEidqjc2JhEbXV zMkhzMoSrPdxpqdmcvckMTywoLwV6dvS4xj/GcW1YqFSCuDSeukraa3FZPcekP5H2K vM7X0YMP+VGj7BR40yAeNsjk7rFDWrC/PuHZfPys= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kyle Tso , Krzysztof Kozlowski , Bart Van Assche , Krzysztof Kozlowski , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.1 303/772] power: supply: core: Remove might_sleep() from power_supply_put() Date: Thu, 12 Dec 2024 15:54:08 +0100 Message-ID: <20241212144402.421640533@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144349.797589255@linuxfoundation.org> References: <20241212144349.797589255@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bart Van Assche [ Upstream commit f6da4553ff24a5d1c959c9627c965323adc3d307 ] The put_device() call in power_supply_put() may call power_supply_dev_release(). The latter function does not sleep so power_supply_put() doesn't sleep either. Hence, remove the might_sleep() call from power_supply_put(). This patch suppresses false positive complaints about calling a sleeping function from atomic context if power_supply_put() is called from atomic context. Cc: Kyle Tso Cc: Krzysztof Kozlowski Fixes: 1a352462b537 ("power_supply: Add power_supply_put for decrementing device reference counter") Signed-off-by: Bart Van Assche Reviewed-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20240917193914.47566-1-bvanassche@acm.org Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/power_supply_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c index ac88c9636b663..13801dfa5c385 100644 --- a/drivers/power/supply/power_supply_core.c +++ b/drivers/power/supply/power_supply_core.c @@ -480,8 +480,6 @@ EXPORT_SYMBOL_GPL(power_supply_get_by_name); */ void power_supply_put(struct power_supply *psy) { - might_sleep(); - atomic_dec(&psy->use_cnt); put_device(&psy->dev); } -- 2.43.0