From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FA84222D77; Thu, 12 Dec 2024 16:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734020961; cv=none; b=NnXTmvGtLardpLiXBQ1IRQUbhxoDeax7vgx/3FrrVocCZMuxqg65AUSCkwb4BUfGT/eWCApBe/6IV6qb0xiJX9kmxUXbEE0yGoecXlsj1kWnLDT0hyACpCmIRdgEPGgYh0AIf7Us0dd+HSjxJ/Nu5/EC3zxgoFRf+ofVlxU6UPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734020961; c=relaxed/simple; bh=QK2wstWghp6GVEWOJXs/5jIrzABJpP8fHUspNftWXKE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FlMl/MgBwLe28FWBUwHI9y7Zs6FdRukutDmYKFX9391N9fBmVe5afvzinONqnkURZwCJa54jN1/vQH/pAP/zoRR+7BLt4m+be9d804Mt20+wtquI4mK9cpMjTgEIObN0W0H/7CBcSghpbfrh87J5pCp0OGUCsJX8oKIPShDbE1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=t0Y7auP2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="t0Y7auP2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FFB3C4CED0; Thu, 12 Dec 2024 16:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734020961; bh=QK2wstWghp6GVEWOJXs/5jIrzABJpP8fHUspNftWXKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t0Y7auP2E2DBFS/qQWmR++mEKuFfcWor3u4z8vJ+WKsEYh3X0eodDfM9CjVcwiNTj TrN+ozgmuG4hu2xVnVgHoe669bq6zn4n4nyRUPXix9E/0wc0iyrMtbK5Z637tioFee xsC3VTx5sD3Z4LDKJ04Giy2AyrxXTX4YdANMQhBE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nicolai Buchwitz , Lino Sanfilippo , =?UTF-8?q?Leonard=20G=C3=B6hrs?= , Marc Kleine-Budde Subject: [PATCH 6.1 608/772] can: dev: can_set_termination(): allow sleeping GPIOs Date: Thu, 12 Dec 2024 15:59:13 +0100 Message-ID: <20241212144415.044688121@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144349.797589255@linuxfoundation.org> References: <20241212144349.797589255@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit ee1dfbdd8b4b6de85e96ae2059dc9c1bdb6b49b5 upstream. In commit 6e86a1543c37 ("can: dev: provide optional GPIO based termination support") GPIO based termination support was added. For no particular reason that patch uses gpiod_set_value() to set the GPIO. This leads to the following warning, if the systems uses a sleeping GPIO, i.e. behind an I2C port expander: | WARNING: CPU: 0 PID: 379 at /drivers/gpio/gpiolib.c:3496 gpiod_set_value+0x50/0x6c | CPU: 0 UID: 0 PID: 379 Comm: ip Not tainted 6.11.0-20241016-1 #1 823affae360cc91126e4d316d7a614a8bf86236c Replace gpiod_set_value() by gpiod_set_value_cansleep() to allow the use of sleeping GPIOs. Cc: Nicolai Buchwitz Cc: Lino Sanfilippo Cc: stable@vger.kernel.org Reported-by: Leonard Göhrs Tested-by: Leonard Göhrs Fixes: 6e86a1543c37 ("can: dev: provide optional GPIO based termination support") Link: https://patch.msgid.link/20241121-dev-fix-can_set_termination-v1-1-41fa6e29216d@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/dev/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/can/dev/dev.c +++ b/drivers/net/can/dev/dev.c @@ -452,7 +452,7 @@ static int can_set_termination(struct ne else set = 0; - gpiod_set_value(priv->termination_gpio, set); + gpiod_set_value_cansleep(priv->termination_gpio, set); return 0; }