From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E062158D80; Thu, 12 Dec 2024 18:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734026428; cv=none; b=RRrdPUt+7XoQqYv9O1J883iO8vph1ZWnyeMjXwyxqp47wwfTeY+H2p4APOxX2u1Y3hFYEt99KC5HzfyFsHh7W98gN82t2CfMFl8gLMceP8JSl5AAUcHhl3hXRbAusrg1SL+EqhGrBcTxn5ngm8diGMZG9Bqsbt731vSiMbCeH0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734026428; c=relaxed/simple; bh=dQY+2W8U7D9MpikoC223IbOWrHB6KZ6Zv03Eg8ixNXM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jyWtYvP+vA1wd7QHzcGAHKRvjhLiFhHBfq8Z1b91SoEfiTaCbHzJJKgaNqEvNupCXv4WRAmPyqFTHcL/1eBbmKPMqB18QkJrQexhFvdSTMQSk9FrXXeFL5mb9XToUU/zD/Mt3FV3F7HgCmBTg7PbzexBcDrcIyoaIUfNbUBjZ8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mEW9QYf7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mEW9QYf7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E569C4CED0; Thu, 12 Dec 2024 18:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734026425; bh=dQY+2W8U7D9MpikoC223IbOWrHB6KZ6Zv03Eg8ixNXM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mEW9QYf7asQoTIv/aby/A86gQjYVUwG/E4lzGk98UIamsy/hY0eG/1ylb7XzmZ9am HM8xRjjKG6tc3Q5awQ6t1xnDmvicDgKt+xYJcPYp7iTpQ/zHlIVtsib+zSXUetvLzs jwXJot08HbMjg2EthF8ffgXnhoTTSrTlOT1Tk9qAL1+Yurbrl8cPSmARAQ1zGNR3xF DGG8+fycxiHEVGT6vLQpVaE4+IiAMHTs62FZnQs6EIbYGQkUvbCKuWT0+efGpYkqty s2UVlRlI56fjd5j4xxBnyhrbzQktOUALY7mIEYX6zLfT4ZauLQ8SUZkPwLxLfoRUzr ZPZ1WAu3cIMFw== Date: Thu, 12 Dec 2024 18:00:23 +0000 From: Eric Biggers To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, patches@lists.linux.dev, Jiri Slaby , Borislav Petkov , "David S. Miller" , Herbert Xu , "H. Peter Anvin" , Ingo Molnar , linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, Thomas Gleixner , x86-ml , Sasha Levin Subject: Re: [PATCH 5.4 243/321] x86/asm/crypto: Annotate local functions Message-ID: <20241212180023.GA112010@google.com> References: <20241212144229.291682835@linuxfoundation.org> <20241212144239.574474355@linuxfoundation.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241212144239.574474355@linuxfoundation.org> On Thu, Dec 12, 2024 at 04:02:41PM +0100, Greg Kroah-Hartman wrote: > 5.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Jiri Slaby > > [ Upstream commit 74d8b90a889022e306b543ff2147a6941c99b354 ] > > Use the newly added SYM_FUNC_START_LOCAL to annotate beginnings of all > functions which do not have ".globl" annotation, but their endings are > annotated by ENDPROC. This is needed to balance ENDPROC for tools that > generate debuginfo. > > These function names are not prepended with ".L" as they might appear in > call traces and they wouldn't be visible after such change. > > To be symmetric, the functions' ENDPROCs are converted to the new > SYM_FUNC_END. > > Signed-off-by: Jiri Slaby > Signed-off-by: Borislav Petkov > Cc: "David S. Miller" > Cc: Herbert Xu > Cc: "H. Peter Anvin" > Cc: Ingo Molnar > Cc: linux-arch@vger.kernel.org > Cc: linux-crypto@vger.kernel.org > Cc: Thomas Gleixner > Cc: x86-ml > Link: https://lkml.kernel.org/r/20191011115108.12392-7-jslaby@suse.cz > Stable-dep-of: 3b2f2d22fb42 ("crypto: x86/aegis128 - access 32-bit arguments as 32-bit") > Signed-off-by: Sasha Levin > --- > arch/x86/crypto/aegis128-aesni-asm.S | 8 ++-- > arch/x86/crypto/aesni-intel_asm.S | 49 ++++++++------------ > arch/x86/crypto/camellia-aesni-avx-asm_64.S | 20 ++++---- > arch/x86/crypto/camellia-aesni-avx2-asm_64.S | 20 ++++---- > arch/x86/crypto/cast5-avx-x86_64-asm_64.S | 8 ++-- > arch/x86/crypto/cast6-avx-x86_64-asm_64.S | 8 ++-- > arch/x86/crypto/chacha-ssse3-x86_64.S | 4 +- > arch/x86/crypto/ghash-clmulni-intel_asm.S | 4 +- > arch/x86/crypto/serpent-avx-x86_64-asm_64.S | 8 ++-- > arch/x86/crypto/serpent-avx2-asm_64.S | 8 ++-- > arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 8 ++-- > 11 files changed, 68 insertions(+), 77 deletions(-) Unless the author of this patch acks this I'd rather you skipped this. It's not worth the risk of regressions in the crypto code. - Eric