From: Greg KH <gregkh@linuxfoundation.org>
To: bin.lan.cn@eng.windriver.com
Cc: stable@vger.kernel.org, gnstark@salutedevices.com,
andy.shevchenko@gmail.com
Subject: Re: [PATCH 6.1] leds: an30259a: Use devm_mutex_init() for mutex initialization
Date: Fri, 13 Dec 2024 12:15:19 +0100 [thread overview]
Message-ID: <2024121313-chemist-factual-1b89@gregkh> (raw)
In-Reply-To: <20241213035206.3518851-1-bin.lan.cn@eng.windriver.com>
On Fri, Dec 13, 2024 at 11:52:06AM +0800, bin.lan.cn@eng.windriver.com wrote:
> From: George Stark <gnstark@salutedevices.com>
>
> [ Upstream commit c382e2e3eccb6b7ca8c7aff5092c1668428e7de6 ]
>
> In this driver LEDs are registered using devm_led_classdev_register()
> so they are automatically unregistered after module's remove() is done.
> led_classdev_unregister() calls module's led_set_brightness() to turn off
> the LEDs and that callback uses mutex which was destroyed already
> in module's remove() so use devm API instead.
>
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Link: https://lore.kernel.org/r/20240411161032.609544-9-gnstark@salutedevices.com
> Signed-off-by: Lee Jones <lee@kernel.org>
> [ Resolve merge conflict in drivers/leds/leds-an30259a.c ]
> Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
> ---
> drivers/leds/leds-an30259a.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
Now deleted, please see:
https://lore.kernel.org/r/2024121322-conjuror-gap-b542@gregkh
for what you all need to do, TOGETHER, to get this fixed and so that I
can accept patches from your company in the future.
thanks,
greg k-h
next prev parent reply other threads:[~2024-12-13 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 3:52 [PATCH 6.1] leds: an30259a: Use devm_mutex_init() for mutex initialization bin.lan.cn
2024-12-13 11:15 ` Greg KH [this message]
2024-12-13 15:13 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024121313-chemist-factual-1b89@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=bin.lan.cn@eng.windriver.com \
--cc=gnstark@salutedevices.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox