public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Csókás, Bence" <csokas.bence@prolan.hu>
Cc: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
	Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH 6.6 resubmit 0/3] Fix PPS channel routing
Date: Fri, 13 Dec 2024 12:41:12 +0100	[thread overview]
Message-ID: <2024121346-omission-regulate-89c3@gregkh> (raw)
In-Reply-To: <20241213112926.44468-1-csokas.bence@prolan.hu>

On Fri, Dec 13, 2024 at 12:29:18PM +0100, Csókás, Bence wrote:
> On certain i.MX8 series parts [1], the PPS channel 0
> is routed internally to eDMA, and the external PPS
> pin is available on channel 1. In addition, on
> certain boards, the PPS may be wired on the PCB to
> an EVENTOUTn pin other than 0. On these systems
> it is necessary that the PPS channel be able
> to be configured from the Device Tree.
> 
> [1] https://lore.kernel.org/all/ZrPYOWA3FESx197L@lizhi-Precision-Tower-5810/
> 
> Francesco Dolcini (3):
>   dt-bindings: net: fec: add pps channel property
>   net: fec: refactor PPS channel configuration
>   net: fec: make PPS channel configurable
> 
>  Documentation/devicetree/bindings/net/fsl,fec.yaml |  7 +++++++
>  drivers/net/ethernet/freescale/fec_ptp.c           | 11 ++++++-----
>  2 files changed, 13 insertions(+), 5 deletions(-)

This series is really totally confusing.  Here's what it looks like in
my mbox:

   1   C Dec 13 Csókás, Bence   (0.8K) [PATCH 6.6 resubmit 0/3] Fix PPS channel routing
   2   C Dec 13 Csókás, Bence   (1.9K) ├─>[PATCH 6.11 v4 2/3] net: fec: refactor PPS channel configuration
   3   C Dec 13 Csókás, Bence   (1.8K) ├─>[PATCH 6.11 v4 3/3] net: fec: make PPS channel configurable
   4   C Dec 13 Csókás, Bence   (1.4K) ├─>[PATCH 6.11 v4 1/3] dt-bindings: net: fec: add pps channel property
   5   C Dec 13 Csókás, Bence   (1.9K) ├─>[PATCH 6.6 resubmit 2/3] net: fec: refactor PPS channel configuration
   6   C Dec 13 Csókás, Bence   (1.8K) ├─>[PATCH 6.6 resubmit 3/3] net: fec: make PPS channel configurable
   7   C Dec 13 Csókás, Bence   (0.9K) ├─>[PATCH 6.11 v4 0/3] Fix PPS channel routing
   8   C Dec 13 Csókás, Bence   (1.4K) └─>[PATCH 6.6 resubmit 1/3] dt-bindings: net: fec: add pps channel property

I see some 6.11 patches (which make no sense as 6.11 is long
end-of-life), and a "resubmit?" for 6.6, but no explaination as to _why_
this is being resubmitted here, or in the patches themselves.

Two different branches in the same series is also really really hard for
any type of tooling to tease apart, making this a manual effort on our
side if we want to deal with them.

What would you do if you got a series that looked like this and had to
handle it?  Would you do what I'm doing now and ask, "What in the world
is going on?"   :)

Please be kind to those on the other side of your emails, make it
blindingly obvious, as to what they need to do with them, AND make it
simple for them to handle the patches.

Series is now deleted from my review queue, sorry.

greg k-h

  parent reply	other threads:[~2024-12-13 11:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 11:29 [PATCH 6.6 resubmit 0/3] Fix PPS channel routing Csókás, Bence
2024-12-13 11:29 ` [PATCH 6.6 resubmit 1/3] dt-bindings: net: fec: add pps channel property Csókás, Bence
2024-12-13 15:12   ` Sasha Levin
2024-12-13 11:29 ` [PATCH 6.6 resubmit 2/3] net: fec: refactor PPS channel configuration Csókás, Bence
2024-12-13 11:29 ` [PATCH 6.6 resubmit 3/3] net: fec: make PPS channel configurable Csókás, Bence
2024-12-13 11:29 ` [PATCH 6.11 v4 0/3] Fix PPS channel routing Csókás, Bence
2024-12-13 11:29 ` [PATCH 6.11 v4 1/3] dt-bindings: net: fec: add pps channel property Csókás, Bence
2024-12-13 11:29 ` [PATCH 6.11 v4 2/3] net: fec: refactor PPS channel configuration Csókás, Bence
2024-12-13 15:13   ` Sasha Levin
2024-12-13 11:29 ` [PATCH 6.11 v4 3/3] net: fec: make PPS channel configurable Csókás, Bence
2024-12-13 11:41 ` Greg Kroah-Hartman [this message]
2024-12-15 17:15   ` [PATCH 6.6 resubmit 0/3] Fix PPS channel routing Csókás Bence
2024-12-17  8:32     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024121346-omission-regulate-89c3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=csokas.bence@prolan.hu \
    --cc=francesco.dolcini@toradex.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox