From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71DB41F75BC; Tue, 17 Dec 2024 17:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734455429; cv=none; b=GuA7M9ySgl0iZLxhEp0JCCFrwiK4PSGqU9q/vpFMVtE6q3bJo0ABt5UsPDaYmO2MQSrznlksU1+iRZjp6ZjfIoRYSWZ7I0LSc3mNoYBnxCgwsBlU9II2cN35ApdF9XlF3/y0mOtOOCelqW+KYTAlfAYVXAM15vEAB3/OyhaO0Ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734455429; c=relaxed/simple; bh=jB7QXOWmYp7jilID6xwlBWou2uSVSesqOaKpAv/gGTE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GqB9C1zX4J0/bbsrcS/MiG6QDVUpxQkSqaiwWewKTogXFswuYiJFkuFRTUALng4V88K2uHqdCW8kD/zWtENEIKoYGMNTjW5uaQg9FiaN3o8BPMNSkfmmaCkOd1PtC920UWJTmXsyyppMd0ogypB/fxUBMRi2mwA+ZVo164GP674= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TIQR1Ydl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TIQR1Ydl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFB44C4CED7; Tue, 17 Dec 2024 17:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734455429; bh=jB7QXOWmYp7jilID6xwlBWou2uSVSesqOaKpAv/gGTE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TIQR1YdlWZuB1vOUyIQXTMIfWffwYiuZX67zD9zHh5fopDYbsXs3FgquIVesOZvKl NZfeDu1FdRcygPZ331TtF3CCmSFaAmIcpwtkX21Umbdwpztj1b6n5cGRvUpqEq4/3w 4xZ2n7dYaBpPKIzfQu2MR3qDEtPnNEgPmB80GHEM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stefan Wahren , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 15/24] qca_spi: Make driver probing reliable Date: Tue, 17 Dec 2024 18:07:13 +0100 Message-ID: <20241217170519.631370817@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241217170519.006786596@linuxfoundation.org> References: <20241217170519.006786596@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Wahren [ Upstream commit becc6399ce3b724cffe9ccb7ef0bff440bb1b62b ] The module parameter qcaspi_pluggable controls if QCA7000 signature should be checked at driver probe (current default) or not. Unfortunately this could fail in case the chip is temporary in reset, which isn't under total control by the Linux host. So disable this check per default in order to avoid unexpected probe failures. Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") Signed-off-by: Stefan Wahren Link: https://patch.msgid.link/20241206184643.123399-3-wahrenst@gmx.net Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index ff477e27a3fe..f051086074a9 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -65,7 +65,7 @@ MODULE_PARM_DESC(qcaspi_burst_len, "Number of data bytes per burst. Use 1-5000." #define QCASPI_PLUGGABLE_MIN 0 #define QCASPI_PLUGGABLE_MAX 1 -static int qcaspi_pluggable = QCASPI_PLUGGABLE_MIN; +static int qcaspi_pluggable = QCASPI_PLUGGABLE_MAX; module_param(qcaspi_pluggable, int, 0); MODULE_PARM_DESC(qcaspi_pluggable, "Pluggable SPI connection (yes/no)."); -- 2.39.5