From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55D791F867E; Tue, 17 Dec 2024 17:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734455749; cv=none; b=Kl6XdEDRRS6O7FEUuTDOx/6SSvOxIlMm+sSXxP48jPmlPqrDc76Bz8GWm/biYd0LeHfiEzYV6UpeVzcdrzJFrEWk5nIrkJttDeMAXqvz6raSBJxoJTx/W7dpYhkA12HkgHPFK0Vh24lDlz6bQxczvaqvKYWs4AcoyIGKQZO6BPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734455749; c=relaxed/simple; bh=Iw7BjFdB1Co/AvTXtA5JdxYzgPXosGz1gMKOXvo1WWo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BVp1+v9a/9SkcIKCj/Dn+aFoAa2ls6Lai9umRwvdl22UUiiwYqN8xLYO+44U5m0/0TV8GYN4vXwVxG9j69UKKZaCdXW75dKjUec3oVSFMq9nWMsPMpEg7Eua2wbZrKpwXquOxucsmymJJAWFI5uKOxw8JrUNzHEV2znYMbjJb5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lLdeDipZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lLdeDipZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6131C4CED3; Tue, 17 Dec 2024 17:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734455749; bh=Iw7BjFdB1Co/AvTXtA5JdxYzgPXosGz1gMKOXvo1WWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lLdeDipZtetcxMitc5v2SKI6S7Hf9NGOQcWWIvmkMdHMNEqilX/aR4ABM2gi/jeJ0 UwUJPPF+ajOpjwqHIbzCBClEync4jsIqNGAeV9tgpXPiUhtdgxwr+FAlp4TM38LWD2 up9/p97nzHgdypj0xSQ3DaIQRMbTH6F7FWirokCw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joe Hattori , Damien Le Moal Subject: [PATCH 6.1 07/76] ata: sata_highbank: fix OF node reference leak in highbank_initialize_phys() Date: Tue, 17 Dec 2024 18:06:47 +0100 Message-ID: <20241217170526.549206023@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241217170526.232803729@linuxfoundation.org> References: <20241217170526.232803729@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joe Hattori commit 676fe1f6f74db988191dab5df3bf256908177072 upstream. The OF node reference obtained by of_parse_phandle_with_args() is not released on early return. Add a of_node_put() call before returning. Fixes: 8996b89d6bc9 ("ata: add platform driver for Calxeda AHCI controller") Signed-off-by: Joe Hattori Signed-off-by: Damien Le Moal Signed-off-by: Greg Kroah-Hartman --- drivers/ata/sata_highbank.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/ata/sata_highbank.c +++ b/drivers/ata/sata_highbank.c @@ -348,6 +348,7 @@ static int highbank_initialize_phys(stru phy_nodes[phy] = phy_data.np; cphy_base[phy] = of_iomap(phy_nodes[phy], 0); if (cphy_base[phy] == NULL) { + of_node_put(phy_data.np); return 0; } phy_count += 1;