* [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
@ 2024-12-18 9:03 chenchangcheng
0 siblings, 0 replies; 9+ messages in thread
From: chenchangcheng @ 2024-12-18 9:03 UTC (permalink / raw)
To: jpoimboe, peterz; +Cc: stable, chenchangcheng
fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0()
fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section
......
fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update()
fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path()
Signed-off-by: chenchangcheng <ccc194101@163.com>
---
tools/objtool/noreturns.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
index f37614cc2c1b..88a0fa8807be 100644
--- a/tools/objtool/noreturns.h
+++ b/tools/objtool/noreturns.h
@@ -49,3 +49,4 @@ NORETURN(x86_64_start_kernel)
NORETURN(x86_64_start_reservations)
NORETURN(xen_cpu_bringup_again)
NORETURN(xen_start_kernel)
+NORETURN(bch2_trans_unlocked_error)
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
@ 2024-12-18 9:05 chenchangcheng
2024-12-18 21:27 ` Josh Poimboeuf
0 siblings, 1 reply; 9+ messages in thread
From: chenchangcheng @ 2024-12-18 9:05 UTC (permalink / raw)
To: jpoimboe, peterz; +Cc: stable, chenchangcheng
fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0()
fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section
......
fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update()
fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path()
Signed-off-by: chenchangcheng <ccc194101@163.com>
---
tools/objtool/noreturns.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
index f37614cc2c1b..b2174894f9f7 100644
--- a/tools/objtool/noreturns.h
+++ b/tools/objtool/noreturns.h
@@ -19,6 +19,7 @@ NORETURN(__x64_sys_exit_group)
NORETURN(arch_cpu_idle_dead)
NORETURN(bch2_trans_in_restart_error)
NORETURN(bch2_trans_restart_error)
+NORETURN(bch2_trans_unlocked_error)
NORETURN(cpu_bringup_and_idle)
NORETURN(cpu_startup_entry)
NORETURN(do_exit)
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-18 9:05 [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns chenchangcheng
@ 2024-12-18 21:27 ` Josh Poimboeuf
2024-12-19 5:51 ` ccc194101
0 siblings, 1 reply; 9+ messages in thread
From: Josh Poimboeuf @ 2024-12-18 21:27 UTC (permalink / raw)
To: chenchangcheng; +Cc: peterz, stable
On Wed, Dec 18, 2024 at 05:05:07PM +0800, chenchangcheng wrote:
> fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0()
> fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section
> ......
> fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update()
> fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path()
>
> Signed-off-by: chenchangcheng <ccc194101@163.com>
Thanks!
Peter, are you able to grab this one?
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
--
Josh
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-18 21:27 ` Josh Poimboeuf
@ 2024-12-19 5:51 ` ccc194101
2024-12-19 22:58 ` Josh Poimboeuf
0 siblings, 1 reply; 9+ messages in thread
From: ccc194101 @ 2024-12-19 5:51 UTC (permalink / raw)
To: jpoimboe; +Cc: peterz, stable, chenchangcheng, chenchangcheng
From: chenchangcheng <ccc194101@163.com>
fix the following objtool warning during build time:
fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0()
fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section
......
fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update()
fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path()
Fixes: fd104e2967b7 ("bcachefs: bch2_trans_verify_not_unlocked()")
Signed-off-by: chenchangcheng <chenchangcheng@kylinos.cn>
---
tools/objtool/noreturns.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
index f37614cc2c1b..b2174894f9f7 100644
--- a/tools/objtool/noreturns.h
+++ b/tools/objtool/noreturns.h
@@ -19,6 +19,7 @@ NORETURN(__x64_sys_exit_group)
NORETURN(arch_cpu_idle_dead)
NORETURN(bch2_trans_in_restart_error)
NORETURN(bch2_trans_restart_error)
+NORETURN(bch2_trans_unlocked_error)
NORETURN(cpu_bringup_and_idle)
NORETURN(cpu_startup_entry)
NORETURN(do_exit)
base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
--
2.25.1
hello,
You can use this new version to add fixes and modify the signed email address.
--
Changcheng Chen
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-19 5:51 ` ccc194101
@ 2024-12-19 22:58 ` Josh Poimboeuf
2024-12-19 22:59 ` Josh Poimboeuf
0 siblings, 1 reply; 9+ messages in thread
From: Josh Poimboeuf @ 2024-12-19 22:58 UTC (permalink / raw)
To: ccc194101; +Cc: peterz, stable, chenchangcheng
On Thu, Dec 19, 2024 at 01:51:57PM +0800, ccc194101@163.com wrote:
> hello,
>
> You can use this new version to add fixes and modify the signed email address.
When updating a patch, please update the title with a new version
number, e.g. "PATCH v2".
--
Josh
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-19 22:58 ` Josh Poimboeuf
@ 2024-12-19 22:59 ` Josh Poimboeuf
2024-12-20 1:27 ` ccc194101
0 siblings, 1 reply; 9+ messages in thread
From: Josh Poimboeuf @ 2024-12-19 22:59 UTC (permalink / raw)
To: ccc194101; +Cc: peterz, stable, chenchangcheng
On Thu, Dec 19, 2024 at 02:59:01PM -0800, Josh Poimboeuf wrote:
> On Thu, Dec 19, 2024 at 01:51:57PM +0800, ccc194101@163.com wrote:
> > hello,
> >
> > You can use this new version to add fixes and modify the signed email address.
>
> When updating a patch, please update the title with a new version
> number, e.g. "PATCH v2".
Also, if it's for upstream, please cc lkml.
--
Josh
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-19 22:59 ` Josh Poimboeuf
@ 2024-12-20 1:27 ` ccc194101
2024-12-20 7:19 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: ccc194101 @ 2024-12-20 1:27 UTC (permalink / raw)
To: jpoimboe; +Cc: peterz, stable, chenchangcheng
>Also, if it's for upstream, please cc lkml.
May I ask what is LKML's email address
--
Changcheng Chen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-20 1:27 ` ccc194101
@ 2024-12-20 7:19 ` Greg KH
2024-12-20 7:22 ` ccc194101
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2024-12-20 7:19 UTC (permalink / raw)
To: ccc194101@163.com; +Cc: jpoimboe, peterz, stable, chenchangcheng
On Fri, Dec 20, 2024 at 09:27:06AM +0800, ccc194101@163.com wrote:
> >Also, if it's for upstream, please cc lkml.
>
>
> May I ask what is LKML's email address
Please use the tool, scripts/get_maintainer.pl which will show you how
to do this. Also, there is a great "how to write a first kernel patch"
tutorial at kernelnewbies.org that you probably should go through first
as well.
good luck!
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Re: [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-20 7:19 ` Greg KH
@ 2024-12-20 7:22 ` ccc194101
0 siblings, 0 replies; 9+ messages in thread
From: ccc194101 @ 2024-12-20 7:22 UTC (permalink / raw)
To: Greg KH; +Cc: jpoimboe, peterz, stable, chenchangcheng
>On Fri, Dec 20, 2024 at 09:27:06AM +0800, ccc194101@163.com wrote:
>> >Also, if it's for upstream, please cc lkml.
>>
>>
>> May I ask what is LKML's email address
>
>Please use the tool, scripts/get_maintainer.pl which will show you how
>to do this. Also, there is a great "how to write a first kernel patch"
>tutorial at kernelnewbies.org that you probably should go through first
>as well.
>
>good luck!
>
>greg k-h
Thanks!
--------------
Changcheng Chen
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-12-20 7:23 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-18 9:05 [PATCH] objtool: add bch2_trans_unlocked_error to bcachefs noreturns chenchangcheng
2024-12-18 21:27 ` Josh Poimboeuf
2024-12-19 5:51 ` ccc194101
2024-12-19 22:58 ` Josh Poimboeuf
2024-12-19 22:59 ` Josh Poimboeuf
2024-12-20 1:27 ` ccc194101
2024-12-20 7:19 ` Greg KH
2024-12-20 7:22 ` ccc194101
-- strict thread matches above, loose matches on Subject: below --
2024-12-18 9:03 chenchangcheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox