From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E13418F2DA for ; Mon, 23 Dec 2024 10:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734950081; cv=none; b=Qb+a3Gix2HxbmLH45fZwj9QBd33Ps9EthSiYORWmGPto/+27q0Lj5oPWgdmuEOHQ3hs72KJf0jOHLZo7sgnpwPXams2mf84no5x2GqOw/rIwY+yeTcvlYHgpuleDiA7WAks6aIzA3hMp+F2vAm/ktognz7mft3B5kDOgVB0GPSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734950081; c=relaxed/simple; bh=ZEJu7UAIfzC+ZVNiu8ah4PP/foenRBcEGmU5xJYcxQ4=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=hwCyb99CLPzFHTntAWSJq/Q8By1wru1lZ5MpDN7Rcl3lNintnGuglwrhYR7+tCfA6H6V1wK7rECJdSw9Fm1Ni/t0eBhMeJwOiMQsxNe2t2hJItfr5y/HBHKPwQvDWrKMKKj1ISLF2dqGyyVqWtd6Z8iohJ/bfAKByPkDVlbgkPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=m00HehZJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m00HehZJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88AA9C4CED3; Mon, 23 Dec 2024 10:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734950081; bh=ZEJu7UAIfzC+ZVNiu8ah4PP/foenRBcEGmU5xJYcxQ4=; h=Subject:To:Cc:From:Date:From; b=m00HehZJ19zlVmsOF1/pxHwC638J/c8mPZnDHuv6xcdZdA3RfMt4MAjhUXZNFvQhR vZSBKCS6W7m+Hm0ahnq/W4GOnARmWu5jHVkkLNKmhjblfb+g3M+BZYk+FGq+7gzG9Y XeJ5PsgEY3zkynGqaTcXptbj3WBl96dFD79fW+mE= Subject: FAILED: patch "[PATCH] selinux: ignore unknown extended permissions" failed to apply to 5.4-stable tree To: tweek@google.com,paul@paul-moore.com Cc: From: Date: Mon, 23 Dec 2024 11:34:22 +0100 Message-ID: <2024122322-wasp-anthem-adcd@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 900f83cf376bdaf798b6f5dcb2eae0c822e908b6 # git commit -s git send-email --to '' --in-reply-to '2024122322-wasp-anthem-adcd@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 900f83cf376bdaf798b6f5dcb2eae0c822e908b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thi=C3=A9baud=20Weksteen?= Date: Thu, 5 Dec 2024 12:09:19 +1100 Subject: [PATCH] selinux: ignore unknown extended permissions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When evaluating extended permissions, ignore unknown permissions instead of calling BUG(). This commit ensures that future permissions can be added without interfering with older kernels. Cc: stable@vger.kernel.org Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls") Signed-off-by: Thiébaud Weksteen Signed-off-by: Paul Moore diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c index 971c45d576ba..3d5c563cfc4c 100644 --- a/security/selinux/ss/services.c +++ b/security/selinux/ss/services.c @@ -979,7 +979,10 @@ void services_compute_xperms_decision(struct extended_perms_decision *xpermd, return; break; default: - BUG(); + pr_warn_once( + "SELinux: unknown extended permission (%u) will be ignored\n", + node->datum.u.xperms->specified); + return; } if (node->key.specified == AVTAB_XPERMS_ALLOWED) { @@ -998,7 +1001,8 @@ void services_compute_xperms_decision(struct extended_perms_decision *xpermd, &node->datum.u.xperms->perms, xpermd->dontaudit); } else { - BUG(); + pr_warn_once("SELinux: unknown specified key (%u)\n", + node->key.specified); } }